Skip to content

Treat an argument with no known refinement as unconstrained #496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CatarinaGamboa wants to merge 2 commits into
base: main
Choose a base branch
from
+18 −1
Open

Treat an argument with no known refinement as unconstrained #496

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e8bb37c
Treat an argument with no known refinement as unconstrained
CatarinaGamboa Nov 6, 2026
54a6de7
Skip the equality only for a bare true, not a true-valued expression
CatarinaGamboa Nov 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions liquidjava-example/src/main/java/testSuite/ErrorUnknownMethodInOperation.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,17 @@ public void lengthPlusOne(String s) {
@Refinement("_ > 0")
int x = s.length() + 1; // Expect: Refinement Error
}

static void take(@Refinement("_ > 0") int amount) {}

static void takeTrue(@Refinement("_ == true") boolean flag) {}

// also when passed straight as an argument (issue #451)
public void lengthAsArgument(String s) {
take(s.length()); // Expect: Refinement Error
}

public void isEmptyAsArgument(String s) {
takeTrue(s.isEmpty()); // Expect: Refinement Error
}
}
6 changes: 5 additions & 1 deletion ...ava/liquidjava/processor/refinement_checker/general_checkers/MethodsFunctionsChecker.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
import liquidjava.processor.refinement_checker.object_checkers.AuxHierarchyRefinementsPassage;
import liquidjava.processor.refinement_checker.object_checkers.AuxStateHandler;
import liquidjava.rj_language.Predicate;
import liquidjava.rj_language.ast.LiteralBoolean;
import liquidjava.rj_language.ast.formatter.ArgumentDisplayNames;
import liquidjava.utils.GeneratedNames;
import liquidjava.utils.Utils;
Expand Down Expand Up @@ -456,7 +457,10 @@ private String createVariableRepresentingArgument(CtExpression<?> iArg, Variable
Predicate met = (Predicate) iArg.getMetadata(Keys.REFINEMENT);
if (met == null)
met = new Predicate();
if (!met.getVariableNames().contains(Keys.WILDCARD))
// a bare `true` means nothing is known about the argument (e.g. the result of an unrefined call), not that it
// equals true
boolean unknown = met.getExpression()instanceof LiteralBoolean b && b.isBooleanTrue();
if (!unknown && !met.getVariableNames().contains(Keys.WILDCARD))
met = Predicate.createEquals(Predicate.createVar(Keys.WILDCARD), met);
String nVar = String.format(Formats.INSTANCE, fArg.getName(), rtc.getContext().getCounter());
rtc.getContext().addInstanceToContext(nVar, fArg.getType(), met.substituteVariable(Keys.WILDCARD, nVar), iArg);
Expand Down
Loading