Repository navigation
Update dependency glob@>=10.2.0 <10.5.0 to v14 [SECURITY] - #776
renovate[bot] wants to merge 1 commit into
Conversation
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
There was a problem hiding this comment.
Note
Newer findings are available below. Devin Review posted a newer report on this PR, in addition to the findings presented here.
🔍 Devin Review: 1 flag
Not posted on this PR by your GitHub settings — view it in Devin Review. (Configure)
473c7d0 to
70fabde
Compare
70fabde to
afe552f
Compare
There was a problem hiding this comment.
Devin Review found 1 new potential issue.
1 flag not posted on this PR by your GitHub settings — view it in Devin Review. (Configure)
| # Renovate security update: [email protected] | ||
| - [email protected] | ||
| # Renovate security update: [email protected] | ||
| - [email protected] |
There was a problem hiding this comment.
🟨 Glob ignore-pattern fix never installs
When installs use this lockfile, [email protected] stays uninstalled despite its release-age exclusion. The lockfile pins [email protected], leaving the ignore-pattern brace expansion denial of service unpatched.
Was this helpful? React with 👍 or 👎 to provide feedback.
This PR contains the following updates:
^10.5.0→^14.0.0Glob: AbortSignal cancellation bypass allows post-timeout filesystem traversal
CVE-2026-118773 / GHSA-3g3m-2fjr-6pw4
More information
Details
Summary
In glob 13.0.6, an aborted async walk rejects or emits an error but continues recursively reading directories in the background.
The root cause is that abort branches in src/walker.ts call cb() without returning. As a result, callers that rely on signal or AbortSignal.timeout() to bound glob traversal cost can still incur filesystem I/O and CPU work after the request has already been rejected.
Details
This was reproduced on glob v13.0.6 (commit e80cb38ae60d6cbff9e75f39032a994858994d35).
The README documents that the signal option cancels the glob walk. However, in src/walker.ts, the following methods call cb() when this.signal?.aborted is true but do not return:
Example vulnerable pattern:
if (this.signal?.aborted) cb()
Because execution continues after cb(), the walker still reaches processor.processPatterns(), readdirCB(), and recursive walkCB2() calls.
The issue was directly demonstrated against v13.0.6. A source-history review shows the same missing-return pattern is present in tagged releases from v9.0.0 through v13.0.6.
The issue affects both glob() and globStream().
Recommended fix:
Change each abort branch to return immediately:
if (this.signal?.aborted) return cb()
Proof of concept
Environment:
Reproduction steps:
Install the affected package:
npm init -y
npm install [email protected]
Run the attached PoC:
node poc/abort-continues-work.mjs
The PoC aborts after the first readdir() call, waits briefly, and counts how many more directory reads happen after the promise has already rejected.
Observed output on the vulnerable version:
{
"rejection": "Error: probe-abort",
"readdirCalls": 1365,
"readdirCallsAtReject": 5,
"readdirCallsAfterReject": 1360
}
Expected behavior:
readdirCallsAfterReject should be 0.
A second PoC using AbortSignal.timeout() also reproduces the issue:
{
"rejection": "TimeoutError: The operation was aborted due to timeout",
"readdirCalls": 133,
"readdirCallsAtReject": 1,
"readdirCallsAfterReject": 132
}
The same test against a patched build with return cb() in the four abort branches stops immediately:
{
"readdirCalls": 1,
"readdirCallsAtReject": 1,
"readdirCallsAfterReject": 0
}
Impact
This is an availability issue.
Applications that expose globbing over attacker-influenced patterns or attacker-controlled directory trees and use AbortSignal / AbortSignal.timeout() as a traversal budget can still perform significant filesystem I/O and CPU work after a request has already timed out or been canceled.
Repeated timed-out requests can stack background glob walks and degrade worker throughput or service availability.
No confidentiality or integrity impact was observed.
Severity
CVSS:4.0/AV:N/AC:L/AT:P/PR:N/UI:N/VC:N/VI:N/VA:L/SC:N/SI:N/SA:NReferences
This data is provided by the GitHub Advisory Database (CC-BY 4.0).
Release Notes
isaacs/node-glob (glob@>=10.2.0 <10.5.0)
v14.0.6Compare Source
ignorepatterns lack the braceExpandMax limit applied topatternFixes GHSA-qxr8-q827-836c: GHSA-qxr8-q827-836c
v14.0.5Compare Source
v14.0.4Compare Source
v14.0.3Compare Source
v14.0.2Compare Source
v14.0.1Compare Source
v14.0.0Compare Source
v13.0.7Compare Source
v13.0.6Compare Source
v13.0.5Compare Source
v13.0.4Compare Source
v13.0.3Compare Source
v13.0.2Compare Source
v13.0.1Compare Source
v13.0.0Compare Source
v12.0.0Compare Source
v11.1.0Compare Source
v11.0.3Compare Source
v11.0.2Compare Source
v11.0.1Compare Source
v11.0.0Compare Source
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.