Repository navigation
fix(rtc-node): return no frames from AudioResampler.flush() when nothing is buffered - #779
Open
ANDROIDHASSAN wants to merge 2 commits into
Open
ANDROIDHASSAN wants to merge 2 commits into
ANDROIDHASSAN wants to merge 2 commits into
Conversation
…ing is buffered The FFI flush response carries a non-zero outputPtr with size 0 when the resampler has nothing left, so the pointer check never matched and flush() returned one 0-sample frame. Check the size instead.
🦋 Changeset detectedLatest commit: 25a85e2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🔍 Devin Review: 1 flag
Not posted on this PR by your GitHub settings — view it in Devin Review. (Configure)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: When nothing is buffered,
AudioResampler.flush()returns one frame withsamplesPerChannel: 0instead of[]. This happens on a fresh resampler and on a second flush. The FFI flush response setsoutputPtrto a non-null buffer address even whensizeis 0, so theif (!res.outputPtr)check never matches.push()gets a 0 pointer for empty output, so it is not affected. Callers that forward flushed frames, for example toAudioSource.captureFrameor an STT stream, receive an empty frame.The Python SDK has the same check and the same bug: livekit/python-sdks#938.
Fix: In
flush(), also return[]whensizeis 0, next to the existingoutputPtrcheck. One line.Tests: I added
src/audio_resampler.test.ts. It runs against the native bindings, likeaudio_source.test.ts.mainit fails:expected [ AudioFrame{ …(5) } ] to deeply equal [], and the received frame hassamplesPerChannel: 0.vitest run srcinpackages/livekit-rtc: 67 passed, 1 skipped. Two e2e files fail to load locally both with and without this change, because they need a builtlivekit-server-sdkand a server. Prettier and ESLint are clean. A@livekit/rtc-nodepatch changeset is included.