Repository navigation
Keep creation-only intent in the saved Goal browser check - #8809
Conversation
Signed-off-by: LoopX Agent <[email protected]>
loopx-agent
left a comment
There was a problem hiding this comment.
Reviewer: model_agent · gpt-6.1-sol · OpenAI · runtime_reported · reasoning_effort=max
Approval conclusion (author-owned PR; GitHub blocks formal self-approval)
评审提交 04881ab6c99ff43d029b1ca5a5df0d507b6035ba,对照目标基线 35c5efbd4b9015f1f784be218d003334f51f0601。没有阻塞发现。
动机 / Motivation
从 Chat 恢复原 Goal 提案的操作者,以及发布或维护打包工作区的贡献者。 打开此前只要求创建的 Goal 提案,在抽屉中补选工作区,再查看重新生成的预览并确认。 打包基线在同一夹具中等待「创建 Goal 并开始首轮」,30 秒后超时。 打包候选通过完整 typed-actions。重建的预览有预期的 workspace_ref,start_execution 缺省,补选零写入,确认为该预览提交一次写入并读回同一提案。 独立验证覆盖从源码构建的打包 Chat 和隔离夹具。作者另报同一发布 wheel 通过,安装版与托管 CI 未独立核验。
改动思路 / Approach
复用既有 typed-actions 场景。测试在原提案抽屉选中工作区后以用户可见的「创建 Goal」继续,并在预览检查实际执行意图。Smoke 保留标准
具体改动 / Changes
关键代码讲解
真实入口保留历史提案意图。确认和读回沿用原提案 ID。同套件的显式首轮 Task 仍覆盖创建并执行。精确提交中的断言 显式执行场景
对主干的风险 / Risks
改动集中在现有测试的 5 行新增和 2 行删除。原确认、精确预览 ID 和持久读回仍在同一浏览器回归检查中。
语义与 CI 对齐
相同打包场景中,基线在旧 CTA 超时,候选完整通过。standard premerge 的 4 项直接和 3 项选中检查通过。
我的整体评价 / Verdict
同意该提交。它恢复打包检查,也能在补选工作区意外要求首轮 Task 时直接失败。
English verdict: APPROVE at 04881ab. The packaged smoke preserves saved creation-only intent and verifies explicit confirmation and readback.
|
This pull request has merge conflicts with Choose the remote for the base repository, not an out-of-date fork. git fetch upstream
git rebase upstream/main
# Resolve each conflict, git add the resolved files, then git rebase --continue.
git push --force-with-lease origin HEADFor a same-repository clone whose Keep the DCO |
Signed-off-by: LoopX Agent <[email protected]>
Summary
The release browser run timed out in the saved Goal workspace-selection scenario. That older proposal requests Goal creation. Selecting a workspace keeps that intent, so the confirmation button reads “创建 Goal”. The test expected the separate action that also submits an initial Task. Release browser failure
Validation
typed-actionsscenario passes with the updated fixture against the packaged main tree and the same installed release wheel.node --check, the bilingual diff gate, and all three selected standard premerge checks pass.