Skip to content

fix: reuse canonical digest matchers in result consumers - #8810

Closed
CharleoYang wants to merge 1 commit into
loopx-project:mainfrom
CharleoYang:codex/digest-owner-repair-20261115
Closed

CharleoYang wants to merge 1 commit into
loopx-project:mainfrom
CharleoYang:codex/digest-owner-repair-20261115

Conversation

@CharleoYang

Copy link
Copy Markdown

Problem and change

Existing Python and TypeScript single-owner regressions found duplicate whole-value SHA-256 matchers in chat image reads, Lark historical image plans, and the native child result inbox.

Reuse the existing canonical digest exports at those consumers. Preserve full-match versus test semantics, type refusals, short-circuit order, errors and caller-specific checks; no runtime match-policy change. Add exactly two Python consumers and one TypeScript consumer to the pinned ownership inventories. These are inventory updates, not exemptions; rejection assertions remain unchanged. The generated Python owner is unchanged.

Focused qualification

Each command ran once: 327 Python passed, 25 TypeScript passed; zero failures or skips. Node 22 was first on PATH, PYTHONPATH unset, usage ping disabled, and temporary files outside the repository.

.venv/bin/python -m pytest -q tests/architecture/test_content_digest_single_owner.py tests/test_manager_context_roundtrip.py::test_existing_return_files_project_without_resending_or_rewriting tests/test_manager_context_roundtrip.py::test_returned_file_http_preserves_bytes_and_filename tests/test_manager_context_roundtrip.py::test_returned_file_http_rechecks_original_source_and_snapshot tests/test_manager_context_roundtrip.py::test_original_steward_history_links_images_but_preserves_bytes_and_cursor tests/test_lark_private_conversations.py::test_original_worker_queues_only_media_for_a_verified_legacy_answer tests/extensions/test_lark_private_result_files.py
node --no-warnings --experimental-sqlite --experimental-strip-types --test --test-concurrency=4 tests/control_plane_ts/content_digest_single_owner.test.ts tests/control_plane_ts/native_child_result_inbox.test.ts

No cumulative/full-suite qualification is claimed. Independent exact-head review is pending. No merge requested.

@CharleoYang

Copy link
Copy Markdown
Author

Overlap note: #8758 repairs two of the same sites (chat result files, native child result inbox) and is still open. This PR is the superset: it also repairs the Lark historical image-result path (loopx/extensions/lark/private_conversations.py:1537,1543) and updates the same pinned ownership inventories, so the two cannot merge independently without conflict. Proposal: merge this one and close #8758 as superseded; do not merge both.

@CharleoYang

Copy link
Copy Markdown
Author

Closing without merge: the owner directed that this work be published on the internal Sankuai remote (origin = ssh://[email protected]/~yangqi45/loopx.git) and not on GitHub. The branch is pushed there; no GitHub PR is required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant