Repository navigation
fix: reuse canonical digest matchers in result consumers - #8810
Closed
CharleoYang wants to merge 1 commit into
Closed
CharleoYang wants to merge 1 commit into
CharleoYang wants to merge 1 commit into
Conversation
Signed-off-by: Qi Yang <[email protected]>
CharleoYang
requested review from
huangruiteng,
loopx-agent,
songoow and
steven-kid
as code owners
November 15, 2026 06:15
Author
|
Overlap note: #8758 repairs two of the same sites (chat result files, native child result inbox) and is still open. This PR is the superset: it also repairs the Lark historical image-result path ( |
9 tasks done
Author
|
Closing without merge: the owner directed that this work be published on the internal Sankuai remote (origin = ssh://[email protected]/~yangqi45/loopx.git) and not on GitHub. The branch is pushed there; no GitHub PR is required. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and change
Existing Python and TypeScript single-owner regressions found duplicate whole-value SHA-256 matchers in chat image reads, Lark historical image plans, and the native child result inbox.
Reuse the existing canonical digest exports at those consumers. Preserve full-match versus test semantics, type refusals, short-circuit order, errors and caller-specific checks; no runtime match-policy change. Add exactly two Python consumers and one TypeScript consumer to the pinned ownership inventories. These are inventory updates, not exemptions; rejection assertions remain unchanged. The generated Python owner is unchanged.
Focused qualification
Each command ran once: 327 Python passed, 25 TypeScript passed; zero failures or skips. Node 22 was first on PATH, PYTHONPATH unset, usage ping disabled, and temporary files outside the repository.
No cumulative/full-suite qualification is claimed. Independent exact-head review is pending. No merge requested.