Skip to content

Verify the scope of Goal creation in Dashboard smoke - #8815

Closed
huangruiteng wants to merge 1 commit into
mainfrom
codex/dashboard-goal-create-smoke-20261115
Closed

huangruiteng wants to merge 1 commit into
mainfrom
codex/dashboard-goal-create-smoke-20261115

Conversation

@huangruiteng

@huangruiteng huangruiteng commented Nov 15, 2026 •

Copy link
Copy Markdown
Collaborator

Goal and delivered outcome

The Dashboard typed-actions smoke restored a stored Goal creation proposal, then waited for “Create Goal and start first run.” That proposal authorizes Goal creation. A start requires an explicit typed request. The same locator timed out on main@c5ff8fdc32b6 and the C1 candidate 638b7e3c23f0. #8805 · #8266

The smoke now confirms the creation-only action, checks the scope of the regenerated preview, and reads back the single committed Goal. Fresh Codex previews in both languages still require start_execution: true and the start action. The replay check counts the durable Goal using the fixture's write counter.

Author declaration

Written by Codex (OpenAI GPT-6). Implemented against the typed Goal creation contract at c5ff8fdc32b6 in loopx/control_plane/goals/creation_execution_review.ts.

Criterion Disposition Verification
Preserve the original authority while regenerating a stored proposal implemented The browser selects a workspace, checks the preview and confirms one durable Goal. Reload verifies the original result.
Require explicit execution intent for a new Codex start preview implemented English and Chinese previews require the typed flag and retain the exact start control.
Keep confirmation idempotent implemented Replaying the original apply leaves the durable write count at one.

Validation

Tested revision 4a21f998631c. Local runs finished. Inputs were synthetic fixtures and isolated backend state.

  • typed-actions, proposal-readback-scope and goal-draft passed in the Dashboard development browser with Node 22.22.3.
  • Six focused real local backend cases passed for historical creation authority and recovery from an initial quota hold.
  • Node syntax, public-boundary scan, and git diff --check passed. Hosted Dashboard validation remains pending.

Scope and continuation

Test update for the Dashboard. UI impact none. The fix targets main so the C1 branch can receive it with its next main sync. The Windows portability repair is tracked separately. #8814

Public boundary checked. The commit is DCO signed.

Continuation

Dashboard validation continues in #8816. Its exact patch passed the stored-proposal and real workspace-selection scenarios when combined with C1 1a3740cf9e6e in an isolated packaged browser check. That PR carries both browser repairs. #8816

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants