Repository navigation
Verify the scope of Goal creation in Dashboard smoke - #8815
Closed
huangruiteng wants to merge 1 commit into
Closed
huangruiteng wants to merge 1 commit into
huangruiteng wants to merge 1 commit into
Conversation
Signed-off-by: LoopX Agent <[email protected]>
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal and delivered outcome
The Dashboard
typed-actionssmoke restored a stored Goal creation proposal, then waited for “Create Goal and start first run.” That proposal authorizes Goal creation. A start requires an explicit typed request. The same locator timed out onmain@c5ff8fdc32b6and the C1 candidate638b7e3c23f0. #8805 · #8266The smoke now confirms the creation-only action, checks the scope of the regenerated preview, and reads back the single committed Goal. Fresh Codex previews in both languages still require
start_execution: trueand the start action. The replay check counts the durable Goal using the fixture's write counter.Author declaration
Written by Codex (OpenAI GPT-6). Implemented against the typed Goal creation contract at
c5ff8fdc32b6inloopx/control_plane/goals/creation_execution_review.ts.Validation
Tested revision
4a21f998631c. Local runs finished. Inputs were synthetic fixtures and isolated backend state.typed-actions,proposal-readback-scopeandgoal-draftpassed in the Dashboard development browser with Node 22.22.3.git diff --checkpassed. Hosted Dashboard validation remains pending.Scope and continuation
Test update for the Dashboard. UI impact
none. The fix targetsmainso the C1 branch can receive it with its next main sync. The Windows portability repair is tracked separately. #8814Public boundary checked. The commit is DCO signed.
Continuation
Dashboard validation continues in #8816. Its exact patch passed the stored-proposal and real workspace-selection scenarios when combined with C1
1a3740cf9e6ein an isolated packaged browser check. That PR carries both browser repairs. #8816