Repository navigation
fix(csapi): sign keys when uploading them. - #960
Merged
devonh merged 1 commit intoNov 12, 2026
Merged
Conversation
devonh
requested changes
Nov 10, 2026
prmadev
force-pushed
the
prmadev/complement-upload-signed-keys
branch
from
November 11, 2026 13:33
57262a7 to
39eb2b0
Compare
Since Matrix version 1.17 uploaded keys must be signed. <https://spec.matrix.org/v1.17/client-server-api/#uploading-keys> > A device uploads the public parts of identity keys to their homeserver > as a signed JSON object, using the /keys/upload API. The JSON object > must include the public part of the device’s Ed25519 key, and must be > signed by that key, as described in Signing JSON. Certain tests in the tests/csapi/device_list_test.go do not do that. To fix that the signature was added to the request. Signed-off-by: Perma Alesheikh <[email protected]>
prmadev
force-pushed
the
prmadev/complement-upload-signed-keys
branch
from
November 11, 2026 13:34
39eb2b0 to
71a2145
Compare
devonh
approved these changes
Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since Matrix version 1.17 uploaded keys must be signed.
Tests in the
tests/csapi/device_list_test.godo not sign the device keys they are uploading. To fix that I added the signature the request.Pull Request Checklist