Repository navigation
fix(heltec_t096): enable the 0x8B5 register patch like the Heltec V4 - #3835
Open
marcelverdult wants to merge 1 commit into
Open
marcelverdult wants to merge 1 commit into
marcelverdult wants to merge 1 commit into
Conversation
Member
|
@Quency-D can you please review this change? |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Heltec T096 never got
SX126X_REGISTER_PATCH=1. Bit 0 of register 0x8B5 (the workaround for the SX1262 AGC lockup on strong adjacent signals) is set for heltec_v4, heltec_v4_r8, heltec_tracker_v2, heltec_rc32 and rak3401, butvariants/heltec_t096/platformio.iniondevhas no such define. This adds the same line the V4 uses.This is the T096 specific part of what #3824 does for all SX1262 boards. If #3824 lands first, this one is redundant.
Refs #3777.
Checked:
Heltec_t096_companion_radio_ble,Heltec_t096_companion_radio_usbandHeltec_t096_repeaterbuild.pio run -t envdumpshowsSX126X_REGISTER_PATCH=1for the BLE companion and the repeater.Not checked: whether this prevents the jump from -95 to -120 reported in #3777. I could not reproduce that jump so far, so I cannot claim it fixes it.