Repository navigation
Conversation
moetemp
force-pushed
the
moe/brook/review/s4-backends
branch
from
October 26, 2026 00:14
b146c64 to
ce8bd6d
Compare
stream_backends= on the client, Worker and Replayer.stream_backends= on the client and Replayer.
moetemp
force-pushed
the
moe/brook/review/s4-backends
branch
from
October 26, 2026 02:08
ce8bd6d to
e453c8e
Compare
moetemp
force-pushed
the
moe/brook/review/s3-data-model
branch
2 times, most recently
from
October 26, 2026 08:44
9e969ce to
9b54b39
Compare
moetemp
force-pushed
the
moe/brook/review/s4-backends
branch
from
October 26, 2026 08:44
e453c8e to
0d0ab14
Compare
moetemp
force-pushed
the
moe/brook/review/s3-data-model
branch
from
October 27, 2026 09:07
9b54b39 to
fda6c46
Compare
moetemp
force-pushed
the
moe/brook/review/s4-backends
branch
2 times, most recently
from
October 27, 2026 09:17
9f62387 to
9afffa1
Compare
moetemp
force-pushed
the
moe/brook/review/s3-data-model
branch
2 times, most recently
from
October 28, 2026 01:33
5a0f9bf to
7a7e940
Compare
moetemp
force-pushed
the
moe/brook/review/s4-backends
branch
2 times, most recently
from
October 28, 2026 07:54
36ed7f5 to
c0c0a86
Compare
moetemp
force-pushed
the
moe/brook/review/s3-data-model
branch
from
October 28, 2026 07:54
7a7e940 to
cbec633
Compare
moetemp
force-pushed
the
moe/brook/review/s3-data-model
branch
from
November 5, 2026 17:19
7cba3a9 to
a6e385a
Compare
moetemp
force-pushed
the
moe/brook/review/s4-backends
branch
2 times, most recently
from
November 5, 2026 23:10
9cfb80a to
98724fe
Compare
moetemp
force-pushed
the
moe/brook/review/s3-data-model
branch
from
November 5, 2026 23:10
a6e385a to
247c20f
Compare
moetemp
force-pushed
the
moe/brook/review/s4-backends
branch
from
November 6, 2026 09:06
98724fe to
b7b7ff1
Compare
moetemp
force-pushed
the
moe/brook/review/s3-data-model
branch
from
November 6, 2026 09:06
247c20f to
8185c1c
Compare
moetemp
force-pushed
the
moe/brook/review/s3-data-model
branch
from
November 6, 2026 09:22
8185c1c to
60b56d3
Compare
moetemp
force-pushed
the
moe/brook/review/s4-backends
branch
from
November 6, 2026 09:22
b7b7ff1 to
6668d55
Compare
Owner
Author
|
Closed in favor of #381, the combined branch, which has this change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
This PR adds
StreamBackend, the base class of the Stream backends, andstream_backends=on the client, the Replayer andWorkflowEnvironment. Each Stream ref keeps its backend's name, so any process can route a ref it gets.default=True, since a replayed create must use the same backend.create_nexus_clientgives a Nexus client that converts each model with the client's converters and codec, as Workflow code does, and calls the runtime in place of an endpoint.Why?
The Redis and memory backends and the Workflow, Activity and client calls all get their runtime from this registration.
Open questions.
StreamBackendsubclassesSimplePluginfor its hooks, butplugins=refuses it. Is that OK?native, though this SDK has no native backend yet. Is that the right default?ClientConfig.stream_backendsisRequired, so a hand-builtClientConfigmust now set it. Is that OK?Part of the Streams review series.
Checklist
poe lintandpytest tests/contrib/streams.