Repository navigation
Conversation
SafeDep Report SummaryPackage Details
This report is generated by SafeDep GitHub App |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0719e79659
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| wget "https://gh-proxy.org/https://github.com/mx-space/core/blob/master/docker-compose.yml" | ||
| wget "https://gh-proxy.org/https://github.com/mx-space/core/blob/v17.0.4/docker-compose.yml" | ||
| ``` | ||
| 本文固定已发布的 v17.0.4 编排。下载后把 app 和 mx-migrate 两处镜像都固定为 `innei/mx-server:17.0.4`,不要让一方使用 latest。未来准备工具尚未包含在该镜像,见 [v18 准备说明](/docs/migrate/v18-preparation)。 |
There was a problem hiding this comment.
Update the upgrade procedure to account for pinned image tags
For installations following this new version-pinning instruction, the Docker update procedure in content/docs/use/update.mdx:16–22 no longer upgrades Core: it only runs docker compose pull && docker compose up -d, leaving both services pinned to 17.0.4. Docker documents that pull fetches the image “associated with a service defined in a compose.yaml file,” not a newer release tag (command reference). Keep the explicit pins, but update the upgrade guide to require selecting a target release and changing both app and mx-migrate tags before pulling; otherwise users following the documented update flow remain on the old release.
Useful? React with 👍 / 👎.




Summary
Document mandatory encryption and configuration migration in the unreleased v18 branch, with published v17.0.4 guidance explicitly versioned.
tmp/dev-encryption.keywith mode0600, reuse it across restarts/workers and prefer explicit keys. Preserve the local key with the development database. Production builds remain strict even underNODE_ENV=development; standalone diagnostics and database promotion need the original effective key explicitly.ENCRYPT_ALGORITHM, CLI--encrypt_algorithmand YAMLencrypt_algorithmas breaking: old values are rejected, field writes are fixed to AES-256-GCM, and historical reads use the default AES-256-ECB only. Custom legacy algorithms must be converted on the prior version with the original key/algorithm before upgrading.migrate.mjs; explain mandatory configuration, credential and AI-metric migrations and the configuration startup ledger guard.migratefollowed by read-onlycheck; the new v18 credential migration also runs after a recorded historical opt-in backfill. Update historical restore guidance and the public agent reference.Companion implementation: mx-space/core#2914
Validation
One existing Astro hint and one classified dead link remain. No site deployment or release performed.