Skip to content

Added Support For TCAN4x5x - #23

Open
gi0rg0sPapamichail wants to merge 4 commits into
odriverobotics:masterfrom
gi0rg0sPapamichail:master
Open

gi0rg0sPapamichail wants to merge 4 commits into
odriverobotics:masterfrom
gi0rg0sPapamichail:master

Conversation

@gi0rg0sPapamichail

Copy link
Copy Markdown

No description provided.

@CLAassistant

CLAassistant commented Nov 9, 2026 •

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@samuelsadok

Copy link
Copy Markdown
Member

I had a quick skim. Some points to address before review:

  • Which boards does this change support?
  • The PR contains a lot of whitespace noise, please remove.
  • Please describe what testing you did.
  • Comments like // 1. Transmit function called by ODriveCAN using your library's exact method names look like LLM left-overs. Those comments are not in the analogous pre-existing glue headers, and they mention "your library", which is unclear what that is. In general, the code should follow conventions from the analogous files.
  • If the code was LLM generated, please confirm that you have reviewed it, have gained a good understanding of what it does, and have corrected any mistakes you could find.

@gi0rg0sPapamichail

gi0rg0sPapamichail commented Nov 9, 2026 via email

Copy link
Copy Markdown
Author

@gi0rg0sPapamichail

Copy link
Copy Markdown
Author

Hello,

I just wanted to follow up on the PR. Have you had a chance to review the code?

If there is still any unnecessary whitespace or formatting noise, could you please specify which files or sections need fixing?

I've also performed additional tests with the TCAN4551 and ODrive controllers, and everything is working as expected.

Thank you for your time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants