Repository navigation
Added Support For TCAN4x5x - #23
Open
gi0rg0sPapamichail wants to merge 4 commits into
Open
gi0rg0sPapamichail wants to merge 4 commits into
gi0rg0sPapamichail wants to merge 4 commits into
Conversation
Member
|
I had a quick skim. Some points to address before review:
|
Author
|
Apologies for the leftover LLM notes in the code—I had a few different
versions on my PC and mixed up the folders before submitting.
Why I opened this pull request: we are using *TCAN4551 CAN chips* to
control our ODrive controllers. Because Texas Instruments' original library
is written in ANSI C and isn't Arduino-compatible, we created our own
Arduino-compatible library for the TCAN modules:
*https://github.com/Hyperion-Robotics/TCAN4x5x/tree/main
<https://github.com/Hyperion-Robotics/TCAN4x5x/tree/main>* *(it's not on
the Arduino Library Manager just yet, but it will be soon cause i made the
fork today)*.
Tested board:
-
Arduino unoR3 using default hardware SPI pins.
-
Built-in automatic SPI pin multiplexing (TCAN4x5x(CS, MISO, MOSI, SCK))
for *ESP32, RP2040 / RP2350, STM32, and Teensy*.
Since I had some trouble understanding the existing wrappers (like
ODriveSTM32CAN.hpp), I worked with an LLM to help structure the wrapper for
the setup.
I’ve tested it with the sine wave CAN example, and everything worked
perfectly,including reading temperatures and current, setting loads, and
running trapezoidal movements. The goal of this fork is to add support for
the TCAN module.
I will soon give you the correct files without the llm notes and white
spaces noise
I am sorry for not checking before doing the fork
Στις Δευ 9 Νοε 2026 στις 3:27 μ.μ., ο/η samuelsadok <
***@***.***> έγραψε:
… *samuelsadok* left a comment (odriverobotics/ODriveArduino#23)
<#23 (comment)>
I had a quick skim. Some points to address before review:
- Which boards does this change support?
- The PR contains a lot of whitespace noise, please remove.
- Please describe what testing you did.
- Comments like // 1. Transmit function called by ODriveCAN using your
library's exact method names look like LLM left-overs. Those comments
are not in the analogous pre-existing glue headers, and they mention "your
library", which is unclear what that is. In general, the code should follow
conventions from the analogous files.
- If the code was LLM generated, please confirm that you have reviewed
it, have gained a good understanding of what it does, and have corrected
any mistakes you could find.
—
Reply to this email directly, view it on GitHub
<#23?email_source=notifications&email_token=BEPAXXTKEGY374E6CGCMA2T5YHA2LA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTMNZUGEZDANBSGU2KM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#issuecomment-6741204254>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BEPAXXTESRVFDZUB6WA2RIT5YHA2LAVCNFSNUABFKJSXA33TNF2G64TZHM3DMMJWHEZTSMRXHNEXG43VMU5TMMRYGYZTEMJRHEY2C5QC>
.
Triage notifications, keep track of coding agent tasks and review pull
requests on the go with GitHub Mobile for iOS
<https://github.com/notifications/mobile/ios/BEPAXXT7NZLXCNTW4RLU3W35YHA2LA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTMNZUGEZDANBSGU2KM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KUZTPN52GK4S7NFXXG>
and Android
<https://github.com/notifications/mobile/android/BEPAXXVSVVX3U2BW537Q7O35YHA2LA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTMNZUGEZDANBSGU2KM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2K4ZTPN52GK4S7MFXGI4TPNFSA>.
Download it today!
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Author
|
Hello, I just wanted to follow up on the PR. Have you had a chance to review the code? If there is still any unnecessary whitespace or formatting noise, could you please specify which files or sections need fixing? I've also performed additional tests with the TCAN4551 and ODrive controllers, and everything is working as expected. Thank you for your time! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.