Repository navigation
Conversation
Pull request dashboard statusWaiting on maintainers · refreshed 2026-11-15 08:20 UTC Merge when ready. Status above doesn't look right?
|
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the declarative configuration schema v1.2.0 update.
No open issues 🎉
What changed in this PR
Updates declarative configuration to schema v1.2.0, connecting supported new fields to existing SDK features and warning when unsupported fields are ignored.
Changes:
- Updates the vendored schema, regenerates models, and accepts
file_format: "1.2"without a version warning. - Adds
always_recordsampler configuration and OTLP HTTP protobuf request-size limits. - Adds unsupported-field warnings, unit tests, and an always-record integration scenario.
| File | Description |
|---|---|
| tests/opentelemetry-docker-tests/tests/declconfig/scenarios/trace_sampler_always_record/scenario.yaml | Defines recording and export expectations. |
| tests/opentelemetry-docker-tests/tests/declconfig/scenarios/trace_sampler_always_record/run.py | Exercises record-only and sampled spans. |
| tests/opentelemetry-docker-tests/tests/declconfig/scenarios/trace_sampler_always_record/otel-config.yaml | Configures the always-record integration scenario. |
| opentelemetry-configuration/tests/test_tracer_provider.py | Tests sampler wiring, request limits, and warnings. |
| opentelemetry-configuration/tests/test_meter_provider.py | Tests request limits and unsupported-field warnings. |
| opentelemetry-configuration/tests/test_logger_provider.py | Tests request limits and unsupported-field warnings. |
| opentelemetry-configuration/src/opentelemetry/configuration/schema.json | Vendors v1.2.0 fields and schema documentation. |
| opentelemetry-configuration/src/opentelemetry/configuration/models.py | Adds generated models for new schema fields. |
| opentelemetry-configuration/src/opentelemetry/configuration/file/_loader.py | Recognizes schema minor version 2. |
| opentelemetry-configuration/src/opentelemetry/configuration/_tracer_provider.py | Applies always-record sampling and request limits; adds warnings. |
| opentelemetry-configuration/src/opentelemetry/configuration/_meter_provider.py | Applies request limits and warns about unsupported settings. |
| opentelemetry-configuration/src/opentelemetry/configuration/_logger_provider.py | Applies request limits and warns about unsupported settings. |
| opentelemetry-configuration/src/opentelemetry/configuration/_common.py | Centralizes unsupported size-limit and attribute-depth warnings. |
Review effort: Balanced
lzchen
approved these changes
Nov 12, 2026
herin049
force-pushed
the
misc/declarative-config-schema-1.2
branch
from
November 15, 2026 08:13
2b0e29e to
71d3fb8
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates the vendored OpenTelemetry configuration schema from v1.1.0 to v1.2.0 and regenerates
models.py.file_formatvalues of1.2are now accepted without a warning.New v1.2.0 fields that map to existing SDK features are now applied:
sampler.always_record->AlwaysRecordSamplerwrapping the configured root samplermax_request_sizeon OTLP HTTP (protobuf) exporters -> the exporter'smax_request_sizeNew fields the SDK doesn't support yet are accepted, but a warning says they will be ignored:
max_response_sizeon all OTLP exportersmax_request_sizeon OTLP gRPC and OTLP HTTP JSON exportersattribute_value_depth_limitonattribute_limits, span limits and log record limitsmeter_provider.view_matching_mode/developmentType of change
Please delete options that are not relevant.
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.
tox -e precommittox -e typecheck