Repository navigation
Conversation
dashpole
force-pushed
the
fix-empty-target-info-3455
branch
from
November 14, 2026 21:44
d1ff693 to
4f890eb
Compare
Pull request dashboard statusWaiting on the author · refreshed 2026-11-15 07:27 UTC Respond to 1 review item (e.g. link a commit, explain why not, ask a follow-up):
Status above doesn't look right?
|
herin049
approved these changes
Nov 15, 2026
| self.assertNotIn("os", prometheus_metric.samples[0].labels) | ||
| self.assertNotIn("version", prometheus_metric.samples[0].labels) | ||
|
|
||
| def test_target_info_omitted_when_resource_empty(self): |
Contributor
There was a problem hiding this comment.
Can we also add one or two scenarios that utilize the self.verify_text_format helper?
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update
_CustomCollector.collectinopentelemetry-exporter-prometheusto only create and yield thetarget_infometric when the merged resource attributes are non-empty, matching the OpenTelemetry Prometheus compatibility specification.(Note: the
otel_scope_infopart of #3455 was superseded byopen-telemetry/opentelemetry-specification#5052and implemented viaotel_scope_*labels in #5123.)Fixes #3455
Type of change
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.
tox -e precommittox -e typecheck