Repository navigation
fix(prometheus): handle metric label key collisions per OpenMetrics specification - #5940
Open
YuvrajLamba01 wants to merge 1 commit into
Open
YuvrajLamba01 wants to merge 1 commit into
YuvrajLamba01 wants to merge 1 commit into
Conversation
…pecification Signed-off-by: Yuvraj Lamba <[email protected]>
|
|
Pull request dashboard statusWaiting on reviewers · refreshed 2026-11-15 11:31 UTC Review the latest changes. Status above doesn't look right?
|
Author
|
/dashboard route:reviewers |
|
@YuvrajLamba01, this pull request was routed to reviewers. The handoff remains active across pushes until newer actionable human feedback arrives. Top-level feedback through this request will not return; unresolved review threads remain open. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3928
Per the OpenTelemetry Prometheus/OpenMetrics compatibility specification, when multiple attribute keys sanitize to identical Prometheus label names, their values must be joined with
;ordered lexicographically by original attribute keys rather than overwriting earlier values.;.Type of change
Checklist: