Repository navigation
ci(release): drop the mirror of the unused Relay image descriptor - #3918
Merged
bobleer merged 2 commits intoNov 14, 2026
Merged
Conversation
The Desktop one-click Relay deploy that consumed relay-image.json was removed in 2f0b61e (GitHub identity / device-owned remote control). Nothing under src/ reads the descriptor or its signature any more, so the mirror only republishes a dangling artifact and pins the sync script to a hard-coded ghcr image namespace. Co-authored-by: OpenBitFun <[email protected]>
bobleer
marked this pull request as ready for review
November 14, 2026 13:26
The dedicated Relay descriptor mirror tests and the relay-image assertion in the sync coverage test pinned behavior that was removed from the sync script in the previous commit. Co-authored-by: OpenBitFun <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mirror_relay_image_descriptorand its floating-manifest publishing fromscripts/openbitfun-release-sync.sh, along with theGITHUB_RELAY_IMAGE_URLwiring and stale comments referencing the descriptor.scripts/linux-binaries-manifest.test.mjs: drop the dedicated Relay descriptor mirror test, remove the relay-image assertion from the sync coverage test, and remove the now-dead relay-image mock from the metadata pinning test.Type and Areas
Type: CI / refactor
Areas: release tooling (mirror sync script + its test)
Motivation / Impact
The Desktop one-click Relay deploy that consumed
relay-image.jsonwas removed in 2f0b61e (GitHub identity / device-owned remote control). Nothing undersrc/reads the descriptor or its signature any more, so the mirror only republishes a dangling artifact — and the descriptor check hard-codes aghcr.io/...image namespace, which would make every sync run fail if the image namespace ever moves.This only removes mirror-side consumption; the release workflow keeps producing
relay-image.jsonuntouched.Verification
bash -n scripts/openbitfun-release-sync.sh— passednode --test scripts/linux-binaries-manifest.test.mjs— 13/13 passnode --test scripts/check-github-config.test.mjs— 60 pass, 0 fail, 2 skippednode --test scripts/relay/package-contract.test.mjs— 8/8 passOPENBITFUN_RELEASE_CHANNEL=stable ./scripts/openbitfun-release-sync.shagainst a sandboxWEBSITE_RELEASE_DIR(full fresh-download path, exit 0): Linux binary manifest mirrored and verified, Desktop assets, Windows installer,latest-v1.jsonanddownloads.jsonall published; no relay-image steps remainShell Deploy Scripts— pass after the test updateReviewer Notes
Rollback: revert the commits. The published
relay-image.json/.sigfiles already on the mirror are untouched by this change; deleting them is a separate ops decision.Generated with OpenBitFun