[MRK2009]

This is based of Karim's patch in FunkinCrew's hxcpp fork

[dimensionscape]

Thanks for this. Two things need to change before it can go in, and I have one question.

1. LIBEXTRA when both HXCPP_M64 and HXCPP_ARM64 are defined. The build tool sets both when the architecture comes from HXCPP_ARCH=arm64 or from the host on an Apple Silicon Mac (set64 in tools/hxcpp/BuildTool.hx). The current lines give .iphonesim-arm64 there. With the new section none of the three lines match, so LIBEXTRA falls through to the generic -64 further down finish-setup.xml and the library gets the wrong name. The current three lines already pick the right suffix in every case, so please leave them as they are.

2. -target is added unconditionally, but its value is only added for HXCPP_M64 or HXCPP_ARM64. A build with neither gets a bare -target that takes -isysroot as its value. Putting the same condition on the flag fixes it: <flag value="-target" if="HXCPP_M64 || HXCPP_ARM64"/>, in both the compiler and the linker.

3. What does -target fix? libhxcpp already builds arm64 simulator libraries with -arch arm64 and -mios-simulator-version-min, so I'd like to see the command and the error you get without it, and the Xcode version. If it's the dylib link, which has no version-min flag, say so in the PR and the commit message, and add a line to Changes.md. CI doesn't build for the simulator, so it can't tell us either way.

Please also drop the whitespace changes and the edit to the commented-out flag, so the diff is only the fix.

[MRK2009]

I'll look when I have time.

[dimensionscape]

Thanks, the LIBEXTRA section is right now: set64 defines both HXCPP_M64 and HXCPP_ARM64 for arm64, and it picks .iphonesim-arm64 there, with the other two cases coming out as before.

The flags won't build, though. Without -target, the triples are bare arguments after -arch arm64, so clang takes arm64-apple-ios-simulator as an input file and fails, in both the compiler and the linker blocks. Either put the flag back in front of them, guarded so there is never a bare -target:

<flag value="-target" if="HXCPP_M64 || HXCPP_ARM64"/>
<flag value="x86_64-apple-ios-simulator" if="HXCPP_M64" unless="HXCPP_ARM64" />
<flag value="arm64-apple-ios-simulator" if="HXCPP_ARM64" />

or drop the triples and keep -arch, if that with -mios-simulator-version-min already does what you need. Which one is right depends on the error you hit, so could you paste it, with your Xcode version? CI has no iOS simulator build, so it won't catch this either way.

The whitespace-only changes on the -arch lines and the edit to the commented-out version-min line can go too, so the diff is just the fix.

[MRK2009]

Yes, but I'm testing stuff with the change after I forked FunkinCrew's hxcpp.

[MRK2009]

The reason why I added -target flag because it could lock the current architecture and won't target the legacy one.

[MRK2009]

Oh actually, I might try drop it because it looks unnecessary.

[dimensionscape]

Thanks for trimming it down. As it stands, though, the section gives the same LIBEXTRA as the three lines on main in every case: .iphonesim-arm64 with HXCPP_ARM64, .iphonesim-64 with HXCPP_M64 alone, and .iphonesim with neither. So it doesn't change any build, and the Changes.md line would say something was fixed when nothing behaves differently.

What did you hit on the simulator? The error, your Xcode version and the command you ran would tell us what actually needs to change. I've cancelled this commit's CI run for now, since it can't change any result and the runners are backed up. It runs again on your next push.

[MRK2009]

It didn't hit any errors though, but tbh I don't have a Mac to test it locally.

But I would consider it as a chore than a fix, so I should probably change the `Changes.md' a bit.

Oh btw, I use 26 in Github Actions.