Skip to content

Take each block's zero lock in the incremental start-age test hook #437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dimensionscape wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −1
Open

Take each block's zero lock in the incremental start-age test hook #437

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/hx/gc/Immix.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7203,7 +7203,16 @@ class GlobalAllocator
{
int oldest = 0;
for(int i=0;i<mAllBlocks.size();i++)
oldest = std::max(oldest, mAllBlocks[i]->maxStartAge());
{
BlockDataInfo *block = mAllBlocks[i];
// Runs between collections, while the zeroing thread may be
// reclaiming or zeroing the block under this lock
int expected = 0;
while (!block->mZeroLock.compare_exchange_weak(expected, 1))
expected = 0;
oldest = std::max(oldest, block->maxStartAge());
block->mZeroLock = 0;
}
return oldest;
}
#endif
Expand Down
Loading