Skip to content

Migrate/minio to boto3 - #1790

Open
L-Agbaria wants to merge 5 commits into
openml:mainfrom
L-Agbaria:migrate/minio-to-boto3
Open

L-Agbaria wants to merge 5 commits into
openml:mainfrom
L-Agbaria:migrate/minio-to-boto3

Conversation

@L-Agbaria

Copy link
Copy Markdown
Member

First iteration of the change, created a new S3Client class which is meant to take over the MinIOClient class.
Added a very basic test that will need to be further developed, ensured that all tests point to the same S3 client instead of MinIO.

There are still some failing tests, this is not the final version but is a partial update to allow for incremental checking and verification.

Metadata

  • Reference Issue: Change MinIO to boto3 #1789
  • New Tests Added: Yes
  • Change Log Entry: Created S3Client and migrated MinIOClient uses to it.

@codecov-commenter

codecov-commenter commented Nov 12, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 67.54386% with 37 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.10%. Comparing base (ccb5244) to head (4dca23a).

Files with missing lines Patch % Lines
openml/_api/clients/s3.py 63.04% 34 Missing ⚠️
openml/_api/resources/dataset.py 71.42% 2 Missing ⚠️
openml/_api/setup/backend.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1790       +/-   ##
===========================================
+ Coverage   49.48%   80.10%   +30.61%     
===========================================
  Files          63       63               
  Lines        5565     5539       -26     
===========================================
+ Hits         2754     4437     +1683     
+ Misses       2811     1102     -1709     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants