Repository navigation
Conversation
Phar::mount() truncated the size of files of 4 GiB or more. The tar writer accepted sizes the tar reader rejects, the zip writer wrapped the central directory offset and size, and compressed sizes above 4 GiB were narrowed. These now fail instead of writing archives that can't be read back. Follow-up to phpGH-25053.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #25054, split out so the PHP-8.4 fix stays small. Phar keeps sizes and offsets in 32-bit fields, and a few writers narrowed larger values without a check:
Phar::mount()stored a file of 4 GiB or more with a truncated size, so reads returned only the low 32 bits worth of data.UINT32_MAX - 511, since GHSA-j3wh-g957-2m85), so the archive could not be opened again.These now fail (mount fails, flush throws a
PharException) instead of writing an archive that can't be read back. The tests need 4 GiB temp files, so they only run withRUN_RESOURCE_HEAVY_TESTS.Refs #25053