Skip to content

Only access system credential storage when needed - #1522

Merged
joshmgross merged 6 commits into
mainfrom
josh/cli-keychain-prompt-1
Nov 13, 2026
Merged

joshmgross merged 6 commits into
mainfrom
josh/cli-keychain-prompt-1

Conversation

@joshmgross

Copy link
Copy Markdown
Contributor

A new installation or build of the pscale CLI will immediately attempt to access the system credential store (ex. macOS Keychain) to load an access token, even if that access token isn't needed.

Instead of loading the access token with the configuration, we can load it only when we need a token. A --help command or one with an access token explicitly supplied don't need to fetch anything from the credential store.

@joshmgross
joshmgross requested a review from a team as a code owner November 12, 2026 22:39

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 9d21f92. Configure here.

Comment thread internal/cmd/auth/logout.go Resolved
@joshmgross
joshmgross merged commit 6196a58 into main Nov 13, 2026
5 checks passed
@joshmgross
joshmgross deleted the josh/cli-keychain-prompt-1 branch November 13, 2026 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants