Repository navigation
Conversation
Collaborator
|
@Bengo7918 please resolve conflicts |
Bengo7918
force-pushed
the
intentiq-identity-module
branch
from
August 19, 2026 12:05
7876272 to
8e552f7
Compare
Author
|
@osulzhenko conflicts resolved :) |
Collaborator
|
@Bengo7918 please update your PR, resolve the merge conflicts, and keep only your commits |
Collaborator
|
@Bengo7918 hello. Kind reminder about the PR. Please clean the PR up because it contains commits that are already present in our main branch. We can't review it unless this is fixed. |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Bengo7918
force-pushed
the
intentiq-identity-module
branch
from
November 10, 2026 19:28
60fd005 to
42511e2
Compare
Author
|
@osulzhenko @Net-burst updated :) The branch is rebased onto the latest master, the conflicts are resolved, and the PR now contains only the IntentIQ Identity module commit (37 files, module + sample config + module/bundle pom entries). |
- Parse abTestUuid from the API response (the snake_case mapper read it as ab_test_uuid, so it was always null). - Keep abTestUuid and tc in cache entries, so reports of cache-served auctions carry them. - Treat a non-2xx API answer as an error instead of caching "no ids". - Remove the in-progress marker when a call fails, so the next request retries; default its TTL to 30s. - Bound L2 reads with cache.l2-timeout-ms, so a hung Redis falls through to the API. - Redis: configurable pool size and wait queue (defaults 32 / 1024), TLS, username, password set as an option. - Report only the highest bid per impression, with its own reports-timeout; count non-2xx reports as errors. - Do not add a resolved eid whose source the request already carries. - Ignore an all-zero device.ifa for pcid and cache keys. - Skip the call when partner-id is blank, or when gdpr=1 without a consent string. - Sample failure logs at 1% without stack traces. - Sample config boots on PBS 4.5 (gdpr.vendorlist.live.startup-cache-dir). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Scope cache keys by partner-id and a digest of the request's privacy signals (gdpr, consent, us_privacy, gpp): no cross-partner sharing, and a changed consent or opt-out is resolved again. - Use the IP/UA device composite only when the request has no stronger id, and leave an lmt=1 ifa out of it. - Skip the impression report without a partner-id, or when GDPR applies without consent. - Concurrent requests for the same user on one instance share one cache lookup and API call, so they are enriched and A/B-attributed too. - Cache the normalized user agent (Caffeine) instead of parsing it on every auction. - README: cache settings other than cache.enabled are host-level. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔧 Type of changes
✨ What's the context?
Adds the
intentiq-identitymodule — a server-side identity-resolution hook. At theprocessed-auction-requeststage it calls the IntentIQ Bid Enhancement S2S API and merges theresolved IDs into
user.eidsbefore the request is sent to bidders. Optionally, at theauction-responsestage it reports winning bids as impressions to a reporting endpoint.The module includes an optional two-layer cache (Caffeine L1 + a pluggable
IdentityStoreL2,Redis by default) with multi-key alias caching, negative caching, and in-progress dedup, plus
per-module custom metrics. Configuration and behavior are documented in the module README.
🧠 Rationale behind the change
Publishers using IntentIQ want server-side ID enrichment without shipping/licensing device
detection to the client. Implemented as a standard PBS module using the hooks framework (no direct
HTTP; uses the framework HttpClient). The L2 store is
@ConditionalOnMissingBean, so partners canswap Redis for their own backend or disable caching entirely. Device detection stays fully
server-side. Trade-off: winning bids are reported server-side rather than as true client renders.
🧪 Test plan
Unit-tested across the module (120 tests) covering the resolution hook, response/impression hook,
caching (L1/L2, negative, in-progress, alias back-fill), TTL policy, metrics, Redis store/stats,
and Spring config. JaCoCo: 97% instruction coverage, no class below 90%. Verified locally with
mvn -f extra/pom.xml -pl modules/intentiq-identity clean test checkstyle:check— all green,0 checkstyle violations. Also smoke-tested the bundle per the README "Running the demo" steps.
🏎Quality check