Repository navigation
feat: expose the Prometheus Metrics library version - #2654
Merged
Merged
Conversation
Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
Contributor
|
zeitlinger
marked this pull request as ready for review
November 5, 2026 17:55
jaydeluca
approved these changes
Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added
io.prometheus.metrics.core.PrometheusMetricsVersion.getVersion()to expose the Maven version of theprometheus-metrics-coreartifact, including-SNAPSHOTduring development. The value is generated from${project.version}during the Maven build.I added a version test, documented the API in the quickstart, and updated the generated core API diff. The packaged core jar and sources jar both include the version API and generated metadata.
mise run test,mise run lint:fix,mise run api-diff, and./mvnw install -DskipTests -DskipITs -Dcoverage.skip=truepassed.mise run buildcompiled the reactor but its exporter integration tests could not run because the container has no Docker socket.Fixes #2645.