Repository navigation
Conversation
test_remote_exec_module_is_removed is parametrized over the gateway fixtures. The first run imports "remote" from its tmp_path and then removes that directory, but the module stays in sys.modules. Later runs then get the stale module back from "import remote", whose source file is gone, and remote_exec() fails with: OSError: could not get source code Remove "remote" from sys.modules before importing it, so each run imports the module it just wrote. Signed-off-by: Khem Raj <raj.khem@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_remote_exec_module_is_removedis parametrized over the gateway fixtures. The first run importsremotefrom itstmp_pathand then removes that directory, but the module stays insys.modules. Every later parametrization gets the stale module back fromimport remote, whose source file is gone, soremote_exec()fails with:Only the first parametrization passes; each one passes when run on its own:
Remove
remotefromsys.modules(viamonkeypatch, so it is restored afterwards) before importing it, so each run imports the module it just wrote. With this change all 6 parametrizations pass (Python 3.14.9, pytest 9.2.0).