Repository navigation
Conversation
Explain startup connection increments and independent stream settings, backed by frame-level coverage of replenishment and protocol limits. Refs python-hyper#1280. Assisted-by: Codex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Document configuring receive windows with automatic flow control
Refs #1280.
The automatic flow-control guide explains acknowledging processed data but does not explain how to enlarge the connection receive window while retaining automatic replenishment. The existing
increment_flow_control_window()already raises the window manager's maximum when the resulting current window exceeds it.Document a one-time startup increment to a 1 MiB connection window, separate 256 KiB stream settings, SETTINGS acknowledgement timing, and subsequent replenishment through
acknowledge_received_data(). Explain the difference between an increment and a target, the current and maximum windows, and the protocol limits. Add the same clarification to the increment method's API documentation. This introduces no API or runtime behavior change.Add 24 frame-level cases using two in-memory peers, with either client or server receiving. They compare default and enlarged connection ACK thresholds over repeated cycles, include padded DATA, check exact WINDOW_UPDATE and SETTINGS/ACK bytes, distinguish connection/stream and send/receive windows, exercise existing and new streams, reach the maximum window without allocating a maximum-sized payload, and cover zero/negative acknowledgements, invalid increments, and negative stream credit after a SETTINGS decrease.
Validation on macOS arm64, CPython 3.12.14:
The full Python matrix and h2spec were not run locally. No network throughput benchmark is claimed. Prepared with AI assistance; external review has not occurred.