Repository navigation
gh-160427: Return None from TextIOWrapper.buffer when detached - #160802
Merged
Merged
Conversation
pythongh-154523 turned the buffer member descriptor into a getter that raises ValueError when the buffer is NULL, and the backport shipped in 3.14.9 and 3.15.1. That made hasattr(stream, "buffer") raise after detach(). Restore the old member descriptor result (None) while keeping the critical section.
cmaloney
added
needs backport to 3.14
Contributor
Author
|
cc: @kumaraditya303 , @vstinner : This attribute changed from returning |
|
Thanks @cmaloney for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14, 3.15. |
|
Sorry, @cmaloney, I could not cleanly backport this to Please backport manually with cherry_picker, see the devguide for more information. |
|
GH-161449 is a backport of this pull request to the 3.15 branch. |
|
GH-161450 is a backport of this pull request to the 3.14 branch. |
cmaloney
added a commit
that referenced
this pull request
Nov 5, 2026
…GH-160802) (#161449) gh-154523 turned the buffer member descriptor into a getter that raises ValueError when the buffer is NULL, and the backport shipped in 3.14.9 and 3.15.1. That made hasattr(stream, "buffer") raise after detach(). Restore the old member descriptor result (None) while keeping the critical section. (cherry picked from commit 3422197) Co-authored-by: Cody Maloney <cmaloney@users.noreply.github.com>
cmaloney
added a commit
that referenced
this pull request
Nov 5, 2026
…GH-160802) (#161450) gh-154523 turned the buffer member descriptor into a getter that raises ValueError when the buffer is NULL, and the backport shipped in 3.14.9 and 3.15.1. That made hasattr(stream, "buffer") raise after detach(). Restore the old member descriptor result (None) while keeping the critical section. (cherry picked from commit 3422197)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gh-154523 turned the buffer member descriptor into a getter that raises ValueError when the buffer is NULL, and the backport shipped in 3.14.9 and 3.15.1. That changed the behavior of
hasattr(stream, "buffer")to raise after.detach(). Restore the old member descriptor result (None) while keeping the critical section for free-threaded safety.hasattr(stream, "buffer")fails with ValueError if buffer is detached #160427