Repository navigation
gh-161452: Fix python -m random with a non-positive integer input - #161453
Open
andresdelfino wants to merge 1 commit into
Open
andresdelfino wants to merge 1 commit into
andresdelfino wants to merge 1 commit into
Conversation
When given a single integer input, main() called randint() inside the same try block that converts the input with int(). The ValueError that randint() raises for an empty range was then taken to mean that the input is not an integer, so "python -m random 0" printed 0.0 and a negative N printed a random negative float, instead of failing like "--integer N" does. Only convert the input inside the try block. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
skirpichev
approved these changes
Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
python -m randomgets a single integer input,main()calledrandint()inside thetryblock that converts the input withint(). For an integerN <= 0, theValueErrorthatrandint()raises for an empty range was taken to mean that the input is not an integer, sopython -m random 0printed0.0and a negativeNprinted a random negative float. This keeps only the conversion inside thetryblock, so an integer input now behaves like--integer N, as documented.The new test checks that
0and-5raise the sameValueErrorwith and without--integer; it fails without the fix.🤖 Generated with Claude Code
python -m random Nprints a float for an integer N <= 0 #161452