[feritcemkahraman]

When a Select popup is rendered in a closed shadow root, clicking inside the popup can close it: the window listener sees the shadow host instead of the clicked element. Preserve the original popup target on the existing mousedown marker so inside clicks stay open and outside clicks still close it. Ref: #1054.

• pnpm exec rc-test --runInBand: 451 tests and 21 snapshots passed, including a real portal into a separate closed shadow root (jsdom).
• ESLint on the changed files: 0 errors, 2 existing warnings.
• tsc --noEmit: 7 errors in existing Jest matcher usages; no errors in the changed files. A real browser was not tested.

Codex assisted with investigation, implementation, and tests.

Summary by CodeRabbit

• 问题修复
  • 修复了 Select 弹窗在闭合 Shadow DOM 中的交互问题：按下弹窗内容时，弹窗不会被误关闭；按下弹窗外部区域时，弹窗仍会正常关闭。

[vercel]

@feritcemkahraman is attempting to deploy a commit to the React Component Team on Vercel.

A member of the Team first needs to authorize it.

[coderabbitai]

No actionable comments were generated in the recent review.

Walkthrough

BaseSelect 在弹出层点击分支中将原始事件目标写入原生事件的 _ori_target 字段。新增测试覆盖两个闭合 Shadow DOM 根中的 Select 和弹出层，并验证不同位置的 mousedown 是否触发关闭。

Changes

闭合 Shadow DOM 点击处理

Layer / File(s)	Summary
记录事件目标并验证点击行为 src/BaseSelect/index.tsx, tests/ShadowTrigger.test.tsx	BaseSelect 将原始 target 写入原生事件的 _ori_target 字段。测试使用实际的 @rc-component/trigger，验证弹出层内容内的 mousedown 不触发关闭，弹出层 Shadow DOM 中的外部元素及 document.body 上的 mousedown 会触发关闭。

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested reviewers: qdyanbing

Merge Risk: Minimal · up to dc1c9

The change preserves inside-popup clicks across closed shadow roots while retaining outside-click closure. No actionable issue remains; the change is ready to merge subject to normal checks.

Pre-merge checks: 5

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		标题准确概括了主要变更：在 closed Shadow DOM 中点击弹出层时保持弹出层打开。
Docstring Coverage		No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 2 files.

Finishing Touches

Generate unit tests (beta)

• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Some tools did not complete. Review the errors below.

ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint install timed out. The project may have too many dependencies for the sandbox.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn

_{小兔看见弹层亮，
闭合影根藏月光。
点中内容窗未关，
点向窗外再收场。
原始目标记清楚，
小兔蹦跳庆新章。}

Recent review info

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: Organization UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: 2d3a872d-9d7d-4bf1-be93-f66186432fd7

Commits

Reviewing files that changed from the base of the PR and between fcbd87e and dc1c937.

Files selected for processing: 2

• src/BaseSelect/index.tsx
• tests/ShadowTrigger.test.tsx

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.