Repository navigation
Draw text with unbounded height on iOS (#59793) - #59793
Merged
Merged
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@jasozh has exported this pull request. If you are a Meta employee, you can view the originating Diff in D127931949. |
Summary: Fixes an issue where text wrapping behavior on iOS differs from Android and web when the text does not fit in its parent container. ### Root Cause On iOS, React Native lays out text during measurement and drawing. `RCTTextLayoutManager::measureNSAttributedString()` uses an unbounded height during measurement to position where text and inline views should be. However, during drawing, the actual frame size is used. When TextKit reaches a point where the next line of text doesn't fit inside the container's height, it stops wrapping and puts everything on the current line. This leads to different wrapping behavior compared to Android and web, especially when inline views are included in text. ### This PR Modify RCTTextLayoutManager so that drawing also uses unbounded height, matching the existing measurement code. This means TextKit never tries to alter wrapping behavior. Changelog: [iOS][Fixed] - Text taller than a fixed-height `<Text>` now wraps normally and is clipped at the bottom edge, matching Android and web Reviewed By: vzaidman Differential Revision: D127931949
meta-codesync
Bot
changed the title
jasozh
force-pushed
the
export-D127931949
branch
from
November 6, 2026 00:16
a828ad9 to
b69e281
Compare
Collaborator
|
This pull request was successfully merged by @jasozh in cd45f30 When will my fix make it into a release? | How to file a pick request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes an issue where text wrapping behavior on iOS differs from Android and web when the text does not fit in its parent container.
Root Cause
On iOS, React Native lays out text during measurement and drawing.
RCTTextLayoutManager::measureNSAttributedString()uses an unbounded height during measurement to position where text and inline views should be. However, during drawing, the actual frame size is used. When TextKit reaches a point where the next line of text doesn't fit inside the container's height, it stops wrapping and puts everything on the current line. This leads to different wrapping behavior compared to Android and web, especially when inline views are included in text.This PR
Modify RCTTextLayoutManager so that drawing also uses unbounded height, matching the existing measurement code. This means TextKit never tries to alter wrapping behavior.
Changelog: [iOS][Fixed] - Text taller than a fixed-height
<Text>now wraps normally and is clipped at the bottom edge, matching Android and webReviewed By: vzaidman
Differential Revision: D127931949