Repository navigation
Correct outdated contributor documentation - #8734
Merged
aurorascharff merged 11 commits intoNov 9, 2026
Merged
Conversation
Size changesDetails📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
aurorascharff
changed the title
aurorascharff
marked this pull request as ready for review
November 7, 2026 22:46
aurorascharff
marked this pull request as draft
November 7, 2026 22:47
aurorascharff
marked this pull request as ready for review
November 7, 2026 22:50
gaearon
reviewed
Nov 9, 2026
| handleChange = (e) => { | ||
| this.setState({value: e.target.value}); | ||
| function Greeting({isLoggedIn}) { | ||
| return do { |
Member
There was a problem hiding this comment.
This example is maybe more confusing than helpful given it was last updated 5 years ago and is not remotely on the way to standardization. I actually struggle to think of relevant features that would be good examples here. Maybe we can remove this section unless you have one.
Collaborator
Author
There was a problem hiding this comment.
Yeah me too I didnt know what to put here? it's kind of weird to say "use standardized features" if we don't have an example.
gaearon
reviewed
Nov 9, 2026
| }, | ||
| "engines": { | ||
| "node": ">=16.8.0" | ||
| "node": "^18.18.0 || ^19.8.0 || >=20.0.0" |
Member
There was a problem hiding this comment.
it's fine to just bump it to newer ones
gaearon
approved these changes
Nov 9, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correct outdated contributor setup instructions and repository references. Require Node 24 or greater in the README and package metadata, and run lint and bundle-analysis CI on Node 24 with fresh dependency caches. Identify Yarn Classic, add the fork remote required by the documented Git workflow, and correct content/cache paths and translation, support, and style-guide links.
Replace the dated ES5-versus-ES6 framing with readable-syntax guidance while preserving the advice about named functions and arrow functions. Remove the obsolete subsection about nonstandard JavaScript features and its examples.
Local validation:
yarn ci-checkandyarn buildpassed under Node 24.22.1. Checked workflow YAML, the engine requirement, and whitespace.