Skip to content

Fix broken search feedback link - #8749

Open
rickvian wants to merge 1 commit into
reactjs:mainfrom
rickvian:codex/issue-6946-docsearch-missing-results
Open

rickvian wants to merge 1 commit into
reactjs:mainfrom
rickvian:codex/issue-6946-docsearch-missing-results

Conversation

@rickvian

Copy link
Copy Markdown

Routes DocSearch's no-results feedback link to React's bug-report form and includes the failed search query in the prefilled title.

Fixes #6946

Test plan

  • Fix: In the local no-results flow, a query containing &, quotes, $, and ? displayed the CTA with the query preserved in the React bug-report URL.
  • URL: Runtime evaluation of the helper confirmed special characters are encoded; GitHub's issue form returned HTTP 302 to sign-in rather than 404.
  • TypeScript: yarn tsc passed.
  • Lint: yarn lint passed with existing <img> warnings; Prettier and git diff --check passed.
  • Human: After signing in to GitHub, follow a generated link and confirm the bug template opens with the query in its title. I did not submit an issue.

@github-actions

Copy link
Copy Markdown

Size changes

Details

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Five Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/404 127.74 KB (🟡 +130 B) 242.89 KB
/500 127.75 KB (🟡 +130 B) 242.9 KB
/[[...markdownPath]] 130.22 KB (🟡 +130 B) 245.37 KB
/errors 127.99 KB (🟡 +130 B) 243.14 KB
/errors/[errorCode] 127.97 KB (🟡 +130 B) 243.12 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

This branch was successfully deployed

1 active deployment
Preview — badfb2df Deployed Nov 10, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Algolia search "Believe this query should return results? Let us know" leads to 404

1 participant