Skip to content

deps: refresh @redocly/openapi-core and bump fast-xml-parser (M12) - #284

Merged
RGood merged 4 commits into
mainfrom
deps/m12-js-yaml-fast-xml-parser
Nov 11, 2026
Merged

RGood merged 4 commits into
mainfrom
deps/m12-js-yaml-fast-xml-parser

Conversation

@RGood

@RGood RGood commented Nov 11, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Fixes two open Dependabot alerts in devvit-docs (M12) without any resolutions override. Only changes that fix an open alert are included.

Change Alert Risk
Refresh the lockfile entry for @redocly/openapi-core (1.34.19 → 1.34.24, same ^1.4.0 range) #107 (high) Patch bump
fast-xml-parser 5.11.1 → 5.12.0 (from Dependabot #280) #160 (low) Minor bump

Details

  • @redocly/openapi-core 1.34.19 pinned js-yaml to exactly 4.3.1. Every release from 1.34.20 onward depends on js-yaml 4.3.2 (latest 1.x is 1.34.24). The lockfile was simply stuck on 1.34.19, so yarn up -R @redocly/openapi-core resolves the fix inside the existing range. package.json is unchanged.
  • This replaces an earlier version of this PR that forced js-yaml@npm:4.3.1 to 4.3.2 through resolutions; thanks @ben-harris-5 for pushing for the cleaner fix. The override has been removed (package.json is identical to main).
  • Result: one js-yaml entry (4.3.2) used by all 10 dependents.
  • Bump fast-xml-parser from 5.11.1 to 5.12.0 #280 is merged in unchanged. fast-xml-parser 5.12.0 also updates its own dependencies within their ranges (@nodable/entities, fast-xml-builder, is-unsafe, strnum).
  • Dependabot Bump js-yaml from 4.3.2 to 5.5.0 #267 (js-yaml 5.5.0, a major bump) is not needed for the alert.
  • Verified locally with the repo's pinned Yarn 4.18.0: yarn install --immutable passes.

Testing

CI build should pass. After merge, confirm the Pages deploy succeeds and that #107 and #160 close.

Not included (separate)

Part of M12 (fix dependency alerts).

@RGood
RGood requested review from a team and ben-harris-5 November 11, 2026 18:03
ben-harris-5
ben-harris-5 previously approved these changes Nov 11, 2026

@ben-harris-5 ben-harris-5 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't like this - would rather upgrade other dependencies to remove the 4.3.1 dep. But this does work, so 🐟

@RGood RGood changed the title deps: force js-yaml 4.3.2 and bump fast-xml-parser (M12) deps: refresh @redocly/openapi-core and bump fast-xml-parser (M12) Nov 11, 2026
@RGood

RGood commented Nov 11, 2026

Copy link
Copy Markdown
Collaborator Author

Reworked per Ben's feedback: the js-yaml resolutions override is gone. Refreshing the lockfile entry for @redocly/openapi-core (1.34.19 → 1.34.24, same ^1.4.0 range) removes the 4.3.1 pin on its own, since 1.34.20+ depend on js-yaml 4.3.2. package.json is now identical to main. Re-requesting review since the push dismisses the earlier approval.

@RGood
RGood requested a review from ben-harris-5 November 11, 2026 18:11

@ben-harris-5 ben-harris-5 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NICE. Same thing maybe for tinypool?

@RGood
RGood merged commit c3bb16e into main Nov 11, 2026
5 checks passed
@RGood
RGood deleted the deps/m12-js-yaml-fast-xml-parser branch November 11, 2026 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants