Repository navigation
deps: fix remaining glob, serialize-javascript and minimatch alerts (M12) - #289
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the remaining fixable Dependabot alerts in
devvit-docs(M12) in one PR. Unlike the earlier lockfile refreshes, this one contains major-version changes andresolutionsoverrides, because the packages involved are pinned by parents that cannot move. Please review it with that in mind.globserialize-javascriptresolutionsentriesminimatch9.0.9copy to^11.0.1(resolves to 11.0.6) with oneresolutionsentryWhy overrides are needed
serialize-javascriptis only used bycopy-webpack-plugin@11(^6.0.0) and[email protected](^6.0.1), both pinned by Docusaurus. The newest versions of those plugins use 7.x but Docusaurus 3.10.2 (the latest stable) does not take them. (terser-webpack-plugin5.6.1 has dropped the dependency, but ours was not the consumer.)minimatch: the only affected copy left afterglobmoves to 14 (which bringsminimatch11) is 9.0.9, used bytypedoc0.28.0.typedoc's newest release usesminimatch10.x, which is also in the vulnerable range (>=7.0.0, <11.0.1), so only 11.x fixes it.typedochas no references outsidepackage.json.npmMinimalAgeGate) blocked the newestglob(14.0.5) andminimatchreleases, so I usedglob14.0.2 and a^11.0.1range forminimatch.Not included
deepmergeAdd PRAW to Devvit web AI migration guide #156 (low): advisory has no patched version (@svgr/plugin-svgo->deepmerge ^4.3.1). Cannot be fixed by an upgrade; handled by dismissal.Verification (local, repo's pinned Yarn 4.18.0)
yarn install --immutablepasses. Lockfile now hasglob14.0.2,minimatch3.1.5 / 5.1.9 / 11.0.6 (the first two are below the affected range),serialize-javascript7.1.4. No affected copies remain.yarn buildsucceeds with the same warnings asmain(5 HTML minifier diagnostics, 2 broken anchors) and the same 11,610 output files.main:css-minimizerwithserialize-javascript7).llms.txtidentical;llms-full.txthas the same lines and size with the section order differing (order also varies between two builds ofmain). Both are generated by the plugins that useglob.runtime~mainbundle (same size, minifier variable names).Risk / rollback
Moderate: major bumps of a direct dependency and of two build-time transitive packages. If the build or deploy misbehaves, revert this single commit. After merge, confirm the Pages deploy succeeds and that #42, #72, #147, #158 and #159 close.
Dependabot #277 (
glob10.5.0 → 14.0.2) becomes redundant.Part of M12 (fix dependency alerts).