Skip to content

feat: Add Needs Attention, Recent Operations, Infrastructure cards to Dashboard (#11627) - #313

Open
keithchong wants to merge 2 commits into
redhat-developer:mainfrom
keithchong:11627-DashboardPart2
Open

keithchong wants to merge 2 commits into
redhat-developer:mainfrom
keithchong:11627-DashboardPart2

Conversation

@keithchong

Copy link
Copy Markdown
Collaborator

See GITOPS-11627

@openshift-ci
openshift-ci Bot requested review from aali309 and wtam2018 November 2, 2026 22:11
@coderabbitai

coderabbitai Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 94661cf4-ecf0-46e3-b506-accd93042bcc

Tip

🎯 Customize your risk assessments

Guide how CodeRabbit assesses merge risk and security architecture risk. Highlight sensitive changes and explain your security boundaries using Merge Risk Instructions and Security Risk Instructions in your review settings. Security architecture risk assessments require the Advanced plan or above.

✅ Automatic approvals, with your rules

Let CodeRabbit approve pull requests once required threads are resolved, pre-merge checks pass, and your risk limits are met. Enable Automatic approvals in review settings, with overrides for teams or file paths.

@codecov-commenter

codecov-commenter commented Nov 2, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0.17730% with 563 lines in your changes missing coverage. Please review.
✅ Project coverage is 13.21%. Comparing base (3bd1dab) to head (fa2800a).
⚠️ Report is 77 commits behind head on main.

Files with missing lines Patch % Lines
...ew/infrastructure/attention/NeedsAttentionCard.tsx 0.00% 106 Missing and 1 partial ⚠️
...iew/infrastructure/operator/GitOpsOperatorCard.tsx 0.00% 63 Missing and 1 partial ⚠️
...overview/infrastructure/shared/resourceEntries.tsx 0.00% 59 Missing and 1 partial ⚠️
...view/infrastructure/argocd/ArgoCDInstancesCard.tsx 0.00% 55 Missing and 1 partial ⚠️
...verview/recent-operations/RecentOperationsCard.tsx 0.00% 53 Missing ⚠️
...frastructure/shared/InfrastructureResourceCard.tsx 0.00% 39 Missing ⚠️
...rview/infrastructure/resources/ResourcesStatus.tsx 0.00% 35 Missing and 1 partial ⚠️
...tops/components/overview/DashboardOverviewPage.tsx 0.00% 18 Missing and 3 partials ⚠️
...mponents/overview/tabs/ApplicationsOverviewTab.tsx 0.00% 18 Missing and 2 partials ⚠️
.../infrastructure/shared/InfrastructureCardTitle.tsx 0.00% 16 Missing ⚠️
... and 15 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #313      +/-   ##
==========================================
+ Coverage   11.30%   13.21%   +1.91%     
==========================================
  Files         169      213      +44     
  Lines        6679     8080    +1401     
  Branches     2235     2771     +536     
==========================================
+ Hits          755     1068     +313     
- Misses       5923     6752     +829     
- Partials        1      260     +259     
Flag Coverage Δ
unit-tests 13.21% <0.17%> (+1.91%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@keithchong
keithchong requested a review from dkarpele November 2, 2026 22:26
@keithchong
keithchong force-pushed the 11627-DashboardPart2 branch 7 times, most recently from 67b324e to cabd778 Compare November 3, 2026 09:02
@dkarpele

dkarpele commented Nov 3, 2026

Copy link
Copy Markdown
Collaborator

@coderabbitai review

@dkarpele

dkarpele commented Nov 4, 2026

Copy link
Copy Markdown
Collaborator
image

When cluster monitoring is disabled and not running Unable to retrieve metrics data message is shown. That looks correct. But there is also misleading message Error occurred running query on Sync count: s: Not Found

@keithchong
keithchong force-pushed the 11627-DashboardPart2 branch from cabd778 to f4a2a85 Compare November 5, 2026 16:42
@keithchong keithchong changed the title feat: Add Needs Attention, Infrastructure cards to Dashboard (#11627) feat: Add Needs Attention, Recent Operations, Infrastructure cards to Dashboard (#11627) Nov 5, 2026
@keithchong
keithchong force-pushed the 11627-DashboardPart2 branch from f4a2a85 to 1527928 Compare November 5, 2026 16:56
Signed-off-by: Keith Chong <kykchong@redhat.com>
@keithchong
keithchong force-pushed the 11627-DashboardPart2 branch from 1527928 to 3248ba2 Compare November 5, 2026 16:59
@keithchong

Copy link
Copy Markdown
Collaborator Author

When cluster monitoring is disabled and not running Unable to retrieve metrics data message is shown. That looks correct. But there is also misleading message Error occurred running query on Sync count: s: Not Found

Thanks @dkarpele . That actually is the error message that I'm getting back from the API. I've changed it to this:

Screenshot 2026-11-05 at 12 01 20 PM

@aali309 aali309 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. a few comments/NIT. Thanks @keithchong

Signed-off-by: Keith Chong <kykchong@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants