Skip to content

pkey: do not retry OSSL_DECODER_from_bio() for DER encoding - #1146

Merged
rhenium merged 1 commit into
ruby:masterfrom
rhenium:ky/pkey-read-perf-der
Nov 10, 2026
Merged

rhenium merged 1 commit into
ruby:masterfrom
rhenium:ky/pkey-read-perf-der

Conversation

@rhenium

@rhenium rhenium commented Nov 9, 2026

Copy link
Copy Markdown
Member

Retries are only needed for PEM input, where they are used to skip PEM blocks that are decoded something else than EVP_PKEY.

Retries are only needed for PEM input, where they are used to skip PEM
blocks that decode into something other than EVP_PKEY. Such cases
should be treated as an error when decoding the input as DER.
@rhenium
rhenium force-pushed the ky/pkey-read-perf-der branch from 82858f4 to b0e3910 Compare November 9, 2026 17:21
@rhenium
rhenium merged commit 7793d6b into ruby:master Nov 10, 2026
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant