Repository navigation
Bump nokogiri to 1.19.7 in shipit - #566
Merged
Merged
Conversation
nokogiri 1.19.1 fails to compile on Ruby head on 64-bit Windows, where rb_range_beg_len now takes rb_len_t (int64_t) pointers instead of long. nokogiri 1.19.5 adapted to rb_len_t, and 1.19.7 also builds against Ruby 4.1.0-preview1.
This was referenced Nov 5, 2026
Merged
k0kubun
approved these changes
Nov 5, 2026
Member
|
merged them in the wrong order, so I just knowingly merged a void, destroying the git history a little. sorry, it's my bad, you did nothing wrong. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This bumps nokogiri in shipit's Gemfile.lock from 1.19.1 to 1.19.7 to fix the
benchmark-default-windows (head)job, which has failed on every run on main since 2026-10-30 (the last passing run was on 2026-10-29).In that job, shipit's
bundle installfails compiling nokogiri 1.19.1 (run 41944045400):xml_node_set.c:382:33: error: passing argument 2 of 'rb_range_beg_len' from incompatible pointer type [-Wincompatible-pointer-types]. ruby/ruby@cc3ba11012 changedrb_range_beg_lento takerb_len_t *, and on 2026-10-29 RubyInstaller's ruby-head build maderb_len_t64 bits (oneclick/rubyinstaller2-packages@0f441be052), so it no longer matches nokogiri'slong. Elsewhererb_len_tis stilllong, which is why the Linux head job passes. nokogiri switched torb_len_tin 1.19.5 (sparklemotion/nokogiri#3711), and 1.19.7 also compiles against Ruby 4.1.0-preview1 (sparklemotion/nokogiri#3755).Of the benchmarks the Windows job runs, only shipit is affected: lobsters, railsbench and erubi-rails lock nokogiri 1.18.9, but that job already excludes them. #567, the Rails 8.1.4.1 bump, makes the same nokogiri change in shipit's Gemfile.lock; the two PRs merge cleanly in either order.
On Linux, with Ruby 4.0.9 and with Ruby master 7f9638f41e, shipit installs and runs. All 57 requests of one benchmark pass return 200 and the same bodies as with 1.19.1, apart from CSRF tokens.