Repository navigation
Conversation
Use docs/_static/img/spatialdata_horizontal.svg (same file as in scverse/spatialdata#1296) for the sidebar logo (html_logo), and point the README banner at the SVG in scverse/spatialdata. The PNG stays in place.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #787 +/- ##
=======================================
Coverage 80.17% 80.17%
=======================================
Files 18 18
Lines 4882 4882
Branches 1085 1085
=======================================
Hits 3914 3914
Misses 604 604
Partials 364 364 🚀 New features to boost your workflow:
|
sphinxext-opengraph cannot render SVG images into social cards and warns for every page, which fails the docs build (warnings are errors).
Same file as in scverse/spatialdata#1296: rendered from the SVG at 2x (1834x428) instead of the old pixelated 917x214 PNG. Used for the opengraph social cards.
jan-glx
marked this pull request as ready for review
November 10, 2026 15:22
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same logo update as scverse/spatialdata#1296: replaces the PNG SpatialData logo with the SVG version.
Changes
docs/_static/img/spatialdata_horizontal.svg: added, identical to the file in docs: replace the PNG logo with an SVG version spatialdata#1296. It is a vector logo: the official scverse icon, plus the Abadi wordmark converted to outlines, with the i-dot tweaked by hand. docs: replace the PNG logo with an SVG version spatialdata#1296 has the details on how it was made.docs/conf.py:html_logonow points to the SVG.README.md: the banner now uses the SVG in scverse/spatialdata. docs: replace the PNG logo with an SVG version spatialdata#1296 is merged, so it already resolves.docs/conf.py:ogp_social_cardsnow uses the PNG. sphinxext-opengraph cannot draw social cards from an SVG, and would otherwise fail the docs build with one warning per page. That is also why the PNG stays; it is now the same 2× re-render of the SVG (1834×428) as in docs: replace the PNG logo with an SVG version spatialdata#1296, replacing the pixelated original.