Repository navigation
Site: data model credits only from the data model's authors.yml (SIT-264) - #85
Merged
Merged
Conversation
…ta model's authors.yml (SIT-264) Without a data-model-authors.yml (the data model branch has no authors.yml), the data model page fell back to authors.yml, which in a storage format build is the storage format's own, and showed its credits. The fallback now applies only when the data model is built on its own.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #80: in a storage format build, the data model page fell back to
authors.ymlwhen the data model branch has noauthors.ymlof its own; in such a build that file is the storage format's, so the data model page showed the storage format's credits (seen in the previews of #82 and #84).The data model page now uses only
data-model-authors.ymlin a storage format build (one with astorage-format.mdpage), andauthors.ymlonly when the data model is built on its own.Tested locally: storage format with
authors.ymland data model without → no credits on the data model page; both with → each page its own.