Repository navigation
docs: v6.7.2 catch-up - #107
Draft
seidroid[bot] wants to merge 1 commit into
Draft
seidroid[bot] wants to merge 1 commit into
seidroid[bot] wants to merge 1 commit into
Conversation
…ded to track the number of distinct peers with a known address (connected peers plus those learned via PEX). (sei-protocol/sei-chain#4520)
Contributor
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Automations to automatically generate PRs for you. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation catch-up for v6.7.2.
1 source PR(s) produced changes across 1 commit(s). Each source PR is a separate commit, so this reviews commit-by-commit.
node/advanced-config-monitoring.mdxtendermint_p2p_known_addresseswas added to track the number of distinct peers with a known address (connected peers plus those learned via PEX).Reviewer notes
release/v6.7: Export known peer address count as a Prometheus gauge sei-chain#4520 — The page already referencestendermint_p2p_peers(for example in the seed-node section) but has no dedicated listing of p2p gauges, so a short addition documentingtendermint_p2p_known_addressesis the cleanest fit. The metric is published at router construction and refreshed every 10s, which matches the existing published-at-construction behavior described fortendermint_p2p_peers.Flagged by a review of every touched page's final text. Each source PR was analysed in isolation, so these were invisible to the per-PR checks. Verify before merging — the checker cannot tell which side of a contradiction is correct.
Analyzing the text for the specified issues:
sc-hash-logger-max-disk-sizedefault contradicts the surrounding text. The prose says "With the default settings, it keeps up to 16 GiB of closed log files," and the table lists the default as17179869184(16 GiB) — consistent. However,sc-hash-logger-target-file-sizeis labeled16777216(16 MiB), while17179869184is labeled 16 GiB; these are internally consistent, so no contradiction here. (No issue.)Pebble metrics described as both always-on-by-default and configurable/off-by-default. Under "Pebble internal metrics," the text says: "FlatKV turns on Pebble's internal metrics for each data DB by default. The node does not apply an
enable-pebble-metricskey fromapp.toml." But under "Pebble estimated read/write metrics," the counters are described as "off by default" and configurable viaenable-read-write-metrics/ss-enable-read-write-metrics. These describe two different metric sets (full internal metrics vs. estimated read/write counters), so not a direct contradiction. (No issue.)NONE
Generated by sei-docs-bridge. Every change is a proposal — verify against the source PRs before merging.