Skip to content

Run the Pydantic v1 test in an overlay and un-skip the gevent test #414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DABH wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Run the Pydantic v1 test in an overlay and un-skip the gevent test #414

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 9 additions & 13 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,21 +138,17 @@ jobs:
- run: mkdir junit-xml
- run: poe test -s --junit-xml=junit-xml/${{ matrix.python }}--${{ matrix.os }}.xml
- run: poe test -s --workflow-environment time-skipping --junit-xml=junit-xml/${{ matrix.python }}--${{ matrix.os }}--time-skipping.xml
# This must remain the last step since it downgrades pydantic
- name: Uninstall pydantic
shell: bash
run: |
echo y | uv run pip uninstall pydantic
echo y | uv run pip uninstall pydantic-core
uv run pip install pydantic==1.10
poe test -s --junit-xml=junit-xml/${{ matrix.python }}--${{ matrix.os }}--pydantic-v1.xml tests/pydantic_converter_v1/workflow_test.py
# Pydantic 1 cannot share a virtualenv with the project's Pydantic 2, so
# run this one test with Pydantic 1 layered over the project environment
# instead of downgrading it in place. The langsmith pytest plugin needs
# Pydantic 2, so it is disabled for this run (its entry point is langsmith_plugin).
- name: Test the Pydantic v1 sample
run: uv run --with "pydantic>=1.10,<2" pytest -s -p no:langsmith_plugin --junit-xml=junit-xml/${{ matrix.python }}--${{ matrix.os }}--pydantic-v1.xml tests/pydantic_converter_v1/workflow_test.py

# On latest, run gevent test
# Run the gevent sample's test on the newest Python in the matrix.
- name: Gevent test
if: ${{ matrix.python == '3.12' }}
run: |
uv sync --group gevent
uv run gevent_async/test/run_combined.py
if: ${{ matrix.python == '3.14' }}
run: uv run --group gevent gevent_async/test/run_combined.py

- name: Upload junit-xml artifacts
uses: actions/upload-artifact@bbbca2ddaa5d8feaa63e36b76fdaad77386f024f # v7
Expand Down
Loading