Repository navigation
Conversation
This was referenced Nov 12, 2026
Both tests shared one workflow ID and one task queue, and the Sentry client and scopes carried over between them, so a worker or breadcrumb from the first test could show up in the second. Each test now gets its own IDs and a fresh client with cleared scopes.
DABH
force-pushed
the
sentry-test-isolation
branch
from
November 13, 2026 18:33
37cd65b to
f45c629
Compare
DABH
enabled auto-merge (squash)
November 13, 2026 19:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR isolates the two Sentry interceptor tests from each other. They shared one workflow ID (
sentry-workflow-id) and one task queue (sentry-task-queue), whilesentry_sdk.initreused the global scopes......but the tests afaict were written to assume independence.
Therefore, each test now uses its own workflow ID and task queue, the fixture clears the global, isolation, and current scopes before
sentry_sdk.initand closes the client afterwards, and the tag assertions use the generated values. Both tests pass repeatedly on Python 3.12 against the local dev server and the time-skipping server; the module still skips itself on 3.14, where the Sentry SDK is unsupported.