Repository navigation
Conversation
These are the files that `poe gen-protos` writes for the Stream service. They are in a PR of their own, so that the hand-written change shows alone.
2 of 3 tasks
…eam. The new Stream WIT gives the Workflow target `append` and `close`, so the generated Workflow `Stream` has them and `async with` closes it.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
This PR adds the generated code of the Streams API, and nothing else. The files are what
poe gen-protoswrites at the head of #2129.temporalio/nexus/system/stream_service/._pb2modules, and the__init__.pyfiles of their packages.temporalio/bridge/_visitor.py, and the two exports intemporalio/workflow/__init__.py.Why?
It's the base of #2129, so that #2129 shows only the hand-written change. Its own base is #2127.
How did you test it?
This branch doesn't pass CI alone. The generated code calls support functions, such as
default_producer(), that #2129 adds. The script that writes these files and the tests are in #2129 too.Link to a test plan if any -