Repository navigation
Fix collector workflow - #328
Merged
Merged
Conversation
masklinn
force-pushed
the
ci-result-fix
branch
4 times, most recently
from
November 4, 2026 20:15
5d45f7e to
8d3816d
Compare
masklinn
enabled auto-merge (squash)
November 4, 2026 20:15
|
Thanks! This looks right to me: with |
If a workflow is skipped, github considers it successful rather than unsuccessful, this is what caused ua-parser#294 to automerge despite errors which had to be fixed in ua-parser#295. By forcing the workflow to run then checking the the requirements were successful it should actually do what it's supposed to... Fixes ua-parser#327 Reported-By: Lucas Sotomayor <lasotomayor20@gmail.com>
masklinn
force-pushed
the
ci-result-fix
branch
from
November 8, 2026 16:20
8d3816d to
e3faa75
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a workflow is skipped, github considers it successful rather than unsuccessful, this is what caused #294 to automerge despite errors which had to be fixed in #295.
By forcing the workflow to run then checking the the requirements were successful it should actually do what it's supposed to...
Fixes #327
Reported-By: Lucas Sotomayor lasotomayor20@gmail.com