Repository navigation
ci: cache the compare tests' ngtsc baseline with vp run - #712
Merged
Merged
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
The Compare tests step compiles every fixture with ngtsc before comparing the output with Oxc's, which takes about 7 minutes of each E2E job. `vp run compare` now runs it as two tasks: `ng-baseline` compiles the fixtures with ngtsc and saves the outputs, cached locally and in the remote task cache, and `compare` compiles them with Oxc and compares the outputs with the saved ones. The baseline script loads only the Angular side of the harness, so the binding, the Rust sources and the comparison code aren't among its inputs. Pull requests read the remote cache anonymously; only pushes to main upload, from a job variant that may request an OIDC token. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Pick the cache mode with an expression instead of a second napi-main job. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Replace the preview build from the registry bridge with the npm release, and drop the .npmrc that pointed @voidzero-dev at the bridge. vite-plus joins the other minimumReleaseAgeExclude entries for toolchain packages. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
fengmk2
force-pushed
the
feat/vp-run-ng-baseline-cache
branch
from
November 12, 2026 06:46
6ea6b26 to
473dc90
Compare
fengmk2
marked this pull request as ready for review
November 12, 2026 07:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The E2E job's Compare tests step compiles every fixture with Angular's compiler (ngtsc) on every PR push, even when nothing that compile depends on changed. That takes about 7 minutes. This caches it with
vp runand its remote task cache, so PRs reuse what main has built.Changes
compare --fixturesis split into two tasks. It compiled every fixture with both ngtsc and Oxc in one run, so the ngtsc compile couldn't be cached on its own. Compare tests now runsvp run compare, which runs the two tasks the rootvite.config.tsdefines:ng-baselinecompiles the fixtures with ngtsc and saves the outputs, thencomparecompiles them with Oxc and compares the result with those outputs.ng-baselineis cached. It reads only the fixtures and the Angular side of the harness, so a change to Oxc still hits.comparereads the Oxc binding, which is built outsidevp run, so it always runs.vp runtracks the files a task reads, song-baselineneeds no input config.Results
Across 131 E2E jobs replayed in a fork:
ng-baselinehit rate: 92%, with 0 false hits