Skip to content

fix(migrate): respect prefer-vite-plus-imports configuration - #3411

Draft
fengmk2 wants to merge 4 commits into
mainfrom
codex/issue-3406-migrate-templates
Draft

fengmk2 wants to merge 4 commits into
mainfrom
codex/issue-3406-migrate-templates

Conversation

@fengmk2

@fengmk2 fengmk2 commented Nov 10, 2026 •

Copy link
Copy Markdown
Member

vp migrate rewrites template imports even when vite-plus/prefer-vite-plus-imports is disabled for those files.

The import rewrite now reads the rule settings from the root lint configuration, including ordered lint.overrides. The same configuration controls migration and lint autofix. Other migration steps retain their current behavior, including dependency, script, catalog, and package-manager override updates.

Closes #3406

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

🚀 Deploying Preview to Cloudflare 🚀

Preview URL: https://codex-issue-3406-migrate-templates-viteplus-dev.voidzero-docs.workers.dev (commit 80778ba)

This URL reflects your latest Preview deployment

Preview Deployments by commit

Status Deployment URL Commit Updated (UTC) See this deployment's details
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://446371bf-viteplus-dev.voidzero-docs.workers.dev 80778ba 2026-11-12T15:51:34.205Z Visit the dashboard ↗
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://bb6908c5-viteplus-dev.voidzero-docs.workers.dev 5b65848 2026-11-12T13:29:06.390Z Visit the dashboard ↗
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://bd91c219-viteplus-dev.voidzero-docs.workers.dev f155722 2026-11-11T08:37:29.838Z Visit the dashboard ↗
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://18161c8b-viteplus-dev.voidzero-docs.workers.dev acccca9 2026-11-10T08:25:39.806Z Visit the dashboard ↗
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://011431fc-viteplus-dev.voidzero-docs.workers.dev 9d32990 2026-11-10T08:24:19.611Z Visit the dashboard ↗
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://dc66070d-viteplus-dev.voidzero-docs.workers.dev fea70b3 2026-11-10T05:37:18.750Z Visit the dashboard ↗

@github-actions

github-actions Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

✅ Staging deployment successful!

Preview: https://viteplus-staging.void.app/
Commit: 80778ba

@github-actions

github-actions Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

CLI artifact sizes (80778ba)

Final release artifacts built by the canonical build-upstream and build-windows-cli actions.
The dist rows use the Linux build. The core total excludes .node files to match the release artifact.

Artifact Format Base PR Change
packages/cli/dist Directory total 2.34 MiB 2.34 MiB +2.01 KiB (+0.08%)
packages/core/dist Directory total 4.11 MiB 4.11 MiB 0 B (0.00%)
Combined package dist Directory total 6.45 MiB 6.45 MiB +2.01 KiB (+0.03%)
vp (Linux x64) Binary 8.35 MiB 8.35 MiB 0 B (0.00%)
vp (Linux x64) gzip -9 3.82 MiB 3.82 MiB 0 B (0.00%)
NAPI (Linux x64) Binary 36.79 MiB 36.81 MiB +16.00 KiB (+0.04%)
NAPI (Linux x64) gzip -9 14.70 MiB 14.71 MiB +9.59 KiB (+0.06%)
vp (macOS ARM64) Binary 5.46 MiB 5.46 MiB 0 B (0.00%)
vp (macOS ARM64) gzip -9 3.25 MiB 3.25 MiB 0 B (0.00%)
NAPI (macOS ARM64) Binary 43.43 MiB 43.45 MiB +16.16 KiB (+0.04%)
NAPI (macOS ARM64) gzip -9 18.87 MiB 18.88 MiB +10.18 KiB (+0.05%)
vp (Windows x64) Binary 6.19 MiB 6.19 MiB 0 B (0.00%)
vp (Windows x64) gzip -9 2.86 MiB 2.86 MiB -2 B (-0.00%)
NAPI (Windows x64) Binary 32.82 MiB 32.84 MiB +19.00 KiB (+0.06%)
NAPI (Windows x64) gzip -9 13.46 MiB 13.47 MiB +9.70 KiB (+0.07%)
Trampoline (Windows x64) Binary 13.50 KiB 13.50 KiB 0 B (0.00%)
Trampoline (Windows x64) gzip -9 7.09 KiB 7.09 KiB 0 B (0.00%)
Installer (Windows x64) Binary 4.68 MiB 4.68 MiB 0 B (0.00%)
Installer (Windows x64) gzip -9 2.25 MiB 2.25 MiB 0 B (0.00%)

@fengmk2
fengmk2 force-pushed the codex/issue-3406-migrate-templates branch from acccca9 to f155722 Compare November 11, 2026 08:36
@fengmk2 fengmk2 added test: e2e Auto run e2e tests test: install-e2e run vite install e2e test test: create-e2e Run `vp create` e2e tests test: sfw labels Nov 11, 2026
@fengmk2 fengmk2 changed the title feat(migrate): add migrate.ignorePatterns fix(migrate): respect prefer-vite-plus-imports configuration Nov 12, 2026
@fengmk2
fengmk2 force-pushed the codex/issue-3406-migrate-templates branch from 5b65848 to 80778ba Compare November 12, 2026 15:50
Comment thread docs/guide/migrate.md
syntax, relative to the root config directory. Later matching overrides can
re-enable the rule.

This controls import rewrites only. Migration still updates dependencies, scripts,

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yangshun This is the currently implemented limitation, other configurations will still undergo migration processing.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test: create-e2e Run `vp create` e2e tests test: e2e Auto run e2e tests test: install-e2e run vite install e2e test test: sfw

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Exclude certain Vite projects from being converted to vite-plus when I do vp migrate

1 participant