Repository navigation
fix(env): accept lts/* and lts/<codename> in env exec --node and env pin - #3437
Open
jong-kyung wants to merge 3 commits into
Open
jong-kyung wants to merge 3 commits into
jong-kyung wants to merge 3 commits into
Conversation
Both commands resolved versions with their own alias handling, which only knew lts and latest. They now share config::resolve_version_alias with vp env use. env pin still validates that an exact version exists.
Collaborator
Author
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Bravo. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
jong-kyung
marked this pull request as ready for review
November 12, 2026 06:59
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vp env exec --nodeandvp env pinrejectedlts/*,lts/<codename>, andlts/-n, althoughvp env useaccepts them. Each command had its own alias handling, which only knewltsandlatest.Both commands now resolve versions through
config::resolve_version_alias, the helper thatvp env usealready uses.Changes
env exec --nodecallsconfig::resolve_version_aliasand no longer has its own resolver.env pinresolves aliases and ranges through the same helper. It still validates that an exact version exists before writing it.Behavior notes
vp env pin lts/*writes the resolved exact version, which matches the existing behavior ofvp env pin lts.Invalid Node.js versionmessage instead of the raw semver error.