Repository navigation
Conversation
flashcode
added
bug
flashcode
requested changes
Nov 14, 2026
jspricke
force-pushed
the
update_hl2file
branch
from
November 14, 2026 20:15
2d83d4a to
16886b7
Compare
- Fix and improve code. - Format using ruff. - Also log notify_private.
jspricke
force-pushed
the
update_hl2file
branch
from
November 14, 2026 20:54
16886b7 to
1b0e55e
Compare
jspricke
commented
Nov 14, 2026
jspricke
left a comment
jspricke
left a comment
Contributor
Author
There was a problem hiding this comment.
Thanks for all the comments!
flashcode
approved these changes
Nov 14, 2026
flashcode
left a comment
flashcode
left a comment
Member
There was a problem hiding this comment.
Thanks for the quick updates, all good now!
I'm going to merge, and I'll add from __future__ import annotations on my side: the str | list[str] annotation needs Python 3.10 or newer, and some still-supported distributions (like RHEL 9, Rocky and Alma) still ship WeeChat built with Python 3.9.
Member
|
Merged in 0798446 (with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Script info
Description
Checklist (script update)
script_name.py X.Y: …