Repository navigation
Support axis-aware any and all reductions - #2967
Open
Sinkleberg wants to merge 1 commit into
Open
Sinkleberg wants to merge 1 commit into
Sinkleberg wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Adds axis arguments to
xt::anyandxt::all, including negative axes, multiple axes, andkeep_dims. Calls without an axis keep their scalar result and short-circuit behavior.The tests also cover empty reductions. For example, reducing a 0 × 3 array over axis 0 produces three false values for
anyand three true values forall, including with immediate evaluation.The full
xtesttarget passed. All 73 math tests passed with SIMD enabled and disabled.Fixes #1555.