Repository navigation
chore(ci): read the Android Firebase app ID from a repository variable - #3991
Merged
Merged
Conversation
1 task
isekovanic
added a commit
that referenced
this pull request
Nov 14, 2026
…ibution changes from develop (#3993) ## 🎯 Goal Bring the CI changes from `develop` to `v9-release`, so its release and sample distribution workflows work with the current secrets and variables. Ports #3990, #3991 and #3992. Ticket: https://linear.app/stream/issue/RN-529 ## 🛠 Implementation details - `examples/SampleApp/fastlane/Fastfile`: the `appstore_api_key` lane uses key ID `8KCMZF773S` (#3990). - `sample-distribution.yml`: - iOS job: no longer passes `MATCH_GIT_BASIC_AUTHORIZATION`. `match` clones over SSH (#3990). - Android job: the S3 APK upload steps are removed (#3990), and `ANDROID_FIREBASE_APP_ID` is read from the repository variable instead of a secret (#3991). - `release.yml`: uses `CI_BOT_GITHUB_TOKEN` instead of `STREAM_CI_GITHUB_BOT_TOKEN` (#3992). Applied to the `v9-release` versions of the files, so nothing else from `develop` comes along. ## 🎨 UI Changes None. ## 🧪 Testing CI only. The next release run on `v9-release` should push and publish as before. ## ☑️ Checklist - [ ] PR targets the `develop` branch (targets `v9-release` on purpose)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Goal
The Android Firebase app ID is an identifier, not a credential (it also ships in the committed
google-services.json), so it doesn't need to be a secret.Ticket: https://linear.app/stream/issue/RN-529
🛠 Implementation details
sample-distribution.ymlnow readsANDROID_FIREBASE_APP_IDfrom a repository variable instead of a secret. The variable is already set to the same value: the app ID ofio.getstream.reactnative.sampleappinstream-chat-internal. TheANDROID_FIREBASE_APP_IDsecret gets deleted once this is merged.🎨 UI Changes
None.
🧪 Testing
CI only. The next
sample-distributionrun ondevelopshould upload the Android sample app to Firebase App Distribution as before.☑️ Checklist
developbranch