Repository navigation
test(inbox): add IterableInboxMessageCell unit tests (SDK-619) - #937
Conversation
Cover default row chrome, custom messageListItemLayout, tap selection, and swipe-to-delete; document the test addition in CHANGELOG.md.
|
Coverage Impact ⬆️ Merging this pull request will increase total coverage on 🛟 Help
|
Re-add tracked .artifacts/feedback files removed by an earlier chore commit on the branch. Use "should …" for all IterableInboxMessageCell test titles.
Remove two `.artifacts/feedback/` files from version control; they belong in local gitignored state only. PR description notes the intentional cleanup.
rtlsilva
left a comment
There was a problem hiding this comment.
Approved with minor comments, and one additional PR-level nit:
The .artifacts/ deletion cites "PROJECT.md Workflow", but there's no PROJECT.md in the repo. .gitignore line 100 (.artifacts/) is the reference reviewers can check.
Revert test-only CHANGELOG entry; assert custom layout replaces default.
Fixed! |

📝 Summary
Adds Jest coverage for inbox row rendering, custom layout, selection, and swipe-delete.
🎟️ Jira Ticket: SDK-619
📖 Description
Introduces
IterableInboxMessageCell.test.tsxfollowing the same style asIterableInboxEmptyState.test.tsx: default layout text and unread indicator, optionalmessageListItemLayout,handleMessageSelecton press, anddeleteRowafter a completed left swipe (withAnimated.timingmocked for synchronous completion).Note (
.artifacts/cleanup): This PR also removes two files under.artifacts/feedback/from version control (search-before-specifying-interface-method.md,search-before-stubbing-interface-method.md). They were added to git by mistake;.gitignorelists.artifacts/(line 100) as local ignored state and they should not be tracked. The deletion is intentional so reviewers do not treat it as unrelated churn—we are correcting the repo, not expanding SDK-619 scope.🧪 How to test?
yarn test src/inbox/components/IterableInboxMessageCell.test.tsxyarn test --coverage🧾 Changelog
No customer facing changes
📹 Loom recording if applicable
N/A — test-only change.
🐞 Github Issues solved
N/A
📚 Docs PR if applicable
N/A