Skip to content

test(inbox): add IterableInboxMessageCell unit tests (SDK-619) - #937

Merged
jferrao-itrbl merged 6 commits into
masterfrom
feature/SDK-619-tests-for-IterableInboxMessageCell
Nov 8, 2026
Merged

jferrao-itrbl merged 6 commits into
masterfrom
feature/SDK-619-tests-for-IterableInboxMessageCell

Conversation

@jferrao-itrbl

@jferrao-itrbl jferrao-itrbl commented Nov 6, 2026 •

Copy link
Copy Markdown
Collaborator

📝 Summary

Adds Jest coverage for inbox row rendering, custom layout, selection, and swipe-delete.

🎟️ Jira Ticket: SDK-619

📖 Description

Introduces IterableInboxMessageCell.test.tsx following the same style as IterableInboxEmptyState.test.tsx: default layout text and unread indicator, optional messageListItemLayout, handleMessageSelect on press, and deleteRow after a completed left swipe (with Animated.timing mocked for synchronous completion).

Note (.artifacts/ cleanup): This PR also removes two files under .artifacts/feedback/ from version control (search-before-specifying-interface-method.md, search-before-stubbing-interface-method.md). They were added to git by mistake; .gitignore lists .artifacts/ (line 100) as local ignored state and they should not be tracked. The deletion is intentional so reviewers do not treat it as unrelated churn—we are correcting the repo, not expanding SDK-619 scope.

🧪 How to test?

  • yarn test src/inbox/components/IterableInboxMessageCell.test.tsx
  • or full suite: yarn test --coverage

🧾 Changelog

No customer facing changes

📹 Loom recording if applicable

N/A — test-only change.

🐞 Github Issues solved

N/A

📚 Docs PR if applicable

N/A

Cover default row chrome, custom messageListItemLayout, tap selection, and
swipe-to-delete; document the test addition in CHANGELOG.md.
@jferrao-itrbl
jferrao-itrbl requested a review from a team as a code owner November 6, 2026 08:35
@jferrao-itrbl
jferrao-itrbl marked this pull request as draft November 6, 2026 08:36
@github-actions

github-actions Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Lines Statements Branches Functions
Coverage: 81%
81.18% (699/861) 70.76% (288/407) 77.37% (212/274)

@qltysh

qltysh Bot commented Nov 6, 2026

Copy link
Copy Markdown

Qlty


Coverage Impact

⬆️ Merging this pull request will increase total coverage on master by 5.3%.

🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

Re-add tracked .artifacts/feedback files removed by an earlier chore commit
on the branch. Use "should …" for all IterableInboxMessageCell test titles.
Remove two `.artifacts/feedback/` files from version control; they belong in
local gitignored state only. PR description notes the intentional cleanup.
@jferrao-itrbl
jferrao-itrbl marked this pull request as ready for review November 6, 2026 08:49

@rtlsilva rtlsilva left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with minor comments, and one additional PR-level nit:

The .artifacts/ deletion cites "PROJECT.md Workflow", but there's no PROJECT.md in the repo. .gitignore line 100 (.artifacts/) is the reference reviewers can check.

Comment thread CHANGELOG.md Resolved
@jferrao-itrbl

Copy link
Copy Markdown
Collaborator Author

Approved with minor comments, and one additional PR-level nit:

The .artifacts/ deletion cites "PROJECT.md Workflow", but there's no PROJECT.md in the repo. .gitignore line 100 (.artifacts/) is the reference reviewers can check.

Fixed!

@jferrao-itrbl
jferrao-itrbl merged commit 682fb51 into master Nov 8, 2026
26 of 27 checks passed
@jferrao-itrbl
jferrao-itrbl deleted the feature/SDK-619-tests-for-IterableInboxMessageCell branch November 8, 2026 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants