Repository navigation
Report locked indexes and index rebuilds at start-up - #6036
Merged
Merged
Conversation
ramonsmits
force-pushed
the
search-engine-locked-index-reporting
branch
from
October 20, 2026 15:02
532637c to
48c4a37
Compare
ramonsmits
commented
Oct 21, 2026
danielmarbach
force-pushed
the
search-engine-locked-index-reporting
branch
from
October 28, 2026 12:15
48c4a37 to
69e09b9
Compare
ramonsmits
marked this pull request as ready for review
November 2, 2026 11:04
ramonsmits
force-pushed
the
search-engine-locked-index-reporting
branch
from
November 2, 2026 11:12
de22afd to
1595aee
Compare
danielmarbach
force-pushed
the
search-engine-locked-index-reporting
branch
from
November 4, 2026 14:07
1595aee to
0687ac2
Compare
ramonsmits
force-pushed
the
search-engine-locked-index-reporting
branch
from
November 4, 2026 15:38
0687ac2 to
d5163c1
Compare
danielmarbach
force-pushed
the
search-engine-locked-index-reporting
branch
from
November 4, 2026 15:49
d5163c1 to
3112532
Compare
ramonsmits
force-pushed
the
search-engine-locked-index-reporting
branch
2 times, most recently
from
November 4, 2026 16:05
d9c3fd9 to
51036cd
Compare
danielmarbach
approved these changes
Nov 4, 2026
ramonsmits
commented
Nov 5, 2026
| } | ||
|
|
||
| var definedIsLucene = IsLucene(definedSearchEngineType); | ||
| Logger.Log(definedIsLucene ? LogLevel.Information : LogLevel.Warning, "Index {IndexName} uses the {SearchEngineType} search engine set in its definition{Note}", index.IndexName, definedSearchEngineType, definedIsLucene ? "" : ". ServiceControl supports only Lucene"); |
Member
Author
There was a problem hiding this comment.
@danielmarbach I guess the intent here is to report if an index has has a (un)supported search engine type. I think I'm ok with these having the same log template for both states but with a different log level just as is happening later in the code . I'm not sure that if we would have used log tempates
Not a fan of the {Note} as its a log template argument but nothing really against it.
Contributor
There was a problem hiding this comment.
@ramonsmits if you prefer, else that's also fine. I care mostly about the other small improvements
Member
Author
|
CI keeps failing, create CI fix: |
danielmarbach
force-pushed
the
search-engine-locked-index-reporting
branch
from
November 5, 2026 10:03
0a30bfe to
26b8432
Compare
danielmarbach
added a commit
that referenced
this pull request
Nov 5, 2026
* Record the RavenDB index search engine and rebuild decision Add an ADR for the decisions in #6034, #6035, #6036 and #6013: ServiceControl no longer writes search engine settings to existing databases, picks the engine of each new or rebuilt index, and reports and approves index definition changes. Link it from the engineering context index. * Cut unnecessary redundancy which is already context in the PRs --------- Co-authored-by: Daniel Marbach <danielmarbach@users.noreply.github.com>
This was referenced Nov 5, 2026
Merged
danielmarbach
added a commit
that referenced
this pull request
Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially addresses:
IndexDeploymentnow logs what it decides at start-up:LockedIgnoreindex started silently with the old definition, and aLockedErrorindex failed with a RavenDB exception.Not included, left for #6015: the number of documents the rebuild covers, a setting that refuses a rebuild at start-up, and the same information in ServiceControl Management before the upgrade.